fix deprecation warning#69
Merged
mikeferguson merged 2 commits intoros-drivers:ros2-develfrom Jul 12, 2020
mikeferguson:fix_deprecation
Merged
fix deprecation warning#69mikeferguson merged 2 commits intoros-drivers:ros2-develfrom mikeferguson:fix_deprecation
mikeferguson merged 2 commits intoros-drivers:ros2-develfrom
mikeferguson:fix_deprecation
Conversation
Member
Author
|
Tested on Foxy with a ust-20lx |
Member
Author
|
This won't work on Dashing, so we should probably merge #71 and do a new/final release to dashing before merging this |
jacobperron
reviewed
Jul 9, 2020
jacobperron
left a comment
There was a problem hiding this comment.
Now that deprecated API has been removed, releasing this patch into rolling should fix http://build.ros2.org/view/Rbin_uF64/job/Rbin_uF64__urg_node__ubuntu_focal_amd64__binary/17/
src/urg_node.cpp
Outdated
| diagnostic_updater_.add("Hardware Status", this, &UrgNode::populateDiagnosticsStatus); | ||
|
|
||
| this->set_on_parameters_set_callback(std::bind(&UrgNode::param_change_callback, this, | ||
| this->add_on_set_parameters_callback(std::bind(&UrgNode::param_change_callback, this, |
There was a problem hiding this comment.
I think we need to hold a reference to the returned shared pointer, otherwise the callback may be unregistered.
Member
Author
|
passes, has crustify issues on F/R - which I'll fix in separate PR |
|
same problem on ubuntu 18.04 dashing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.