Merged
Conversation
56ad907 to
0a0e2fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 33.12% 37.36% +4.23%
==========================================
Files 12 23 +11
Lines 1123 2200 +1077
Branches 740 1338 +598
==========================================
+ Hits 372 822 +450
- Misses 103 182 +79
- Partials 648 1196 +548
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0a0e2fb to
d537a84
Compare
d537a84 to
9de8481
Compare
This parameter is required by the forward_command_controller
55e6ff9 to
3dd3311
Compare
bmagyar
reviewed
Oct 4, 2020
bmagyar
reviewed
Oct 4, 2020
bmagyar
reviewed
Oct 4, 2020
Member
bmagyar
left a comment
There was a problem hiding this comment.
Looks good in general, minor comments
The test comment could be addressed in a follow-up
bmagyar
approved these changes
Oct 6, 2020
fmauch
pushed a commit
to fmauch/ros2_controllers
that referenced
this pull request
Feb 23, 2022
* Checking if new data has been send by the command interface * Fixed issue which caused a delay in the SJTC when sending multiple goals * Removed both attention flags in the Readme related to the move to home bug Co-authored-by: Marvin Große Besselmann <grosse@fzi.de>
Closed
gwalck
pushed a commit
to b-robotized-forks/ros2_controllers
that referenced
this pull request
Jun 7, 2023
* Open Robotics' initial transmission interface version * Rework the parser into a standalone function * Rework & extend tests with gmock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of position_controllers from ROS1.
Closes #50 .