[JTC] Add option to hold position on last command#794
Closed
christophfroehlich wants to merge 3 commits intoros-controls:masterfrom
Closed
[JTC] Add option to hold position on last command#794christophfroehlich wants to merge 3 commits intoros-controls:masterfrom
christophfroehlich wants to merge 3 commits intoros-controls:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
===========================================
- Coverage 45.29% 30.88% -14.41%
===========================================
Files 40 7 -33
Lines 3663 832 -2831
Branches 1730 505 -1225
===========================================
- Hits 1659 257 -1402
+ Misses 821 133 -688
+ Partials 1183 442 -741
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
@christophfroehlich Thanks for adding this option. I am not sure actually about the use case. But I think reusing the parameter could be quite confusing |
Member
Author
|
See #811, we will use a different solution. |
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
Co-authored-by: Denis Štogl <denis@stogl.de> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested with #759, there is now an option to hold the position of the last command instead of the state read from the hardware.
I added a new parameter, but we could also use the already existing
open_loop_control? @firesurfer Is there a use case foropen_loop_control==falsebut one would like to hold the last commanded point?Still missing:
This closes #759