[JTC] Rename normalize_error to angle_wraparound parameter#772
Merged
bmagyar merged 1 commit intoros-controls:masterfrom Sep 13, 2023
Merged
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 35.78% 30.88% -4.90%
==========================================
Files 189 7 -182
Lines 17570 832 -16738
Branches 11592 505 -11087
==========================================
- Hits 6287 257 -6030
+ Misses 994 133 -861
+ Partials 10289 442 -9847
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit cad7894)
bmagyar
pushed a commit
that referenced
this pull request
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a very old issue and realized that
normalize_errorwas calledangle_wraparoundin ROS 1. I renamed the parameter because the old naming is more descriptive from a user perspective (and some user might be familiar with the old name)Closes #85