[JTC] Remove wrong description about specialized versions#742
Merged
bmagyar merged 1 commit intoros-controls:masterfrom Aug 15, 2023
Merged
[JTC] Remove wrong description about specialized versions#742bmagyar merged 1 commit intoros-controls:masterfrom
bmagyar merged 1 commit intoros-controls:masterfrom
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #742 +/- ##
==========================================
- Coverage 35.78% 30.88% -4.90%
==========================================
Files 189 7 -182
Lines 17570 832 -16738
Branches 11592 505 -11087
==========================================
- Hits 6287 257 -6030
+ Misses 994 133 -861
+ Partials 10289 442 -9847
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
(cherry picked from commit 5178503)
bmagyar
pushed a commit
that referenced
this pull request
Aug 17, 2023
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
…-controls#742) Add code for deactivating controller when hardware gets an error on read and write. Fix misleading variable name in the tests. Remove all interface from available list for hardware when an error happens. Do some more variable renaming to the new nomenclature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the wrong description from the docs.
We decided in the last WG meeting that we won't implement the specialized versions of JTC -> If the usage of JTC is not clear we should improve the docs instead of adding additional code.