Fixing tests for #706 (backport #705)#735
Merged
bmagyar merged 3 commits intoros-controls:mergify/bp/humble/pr-705from Aug 4, 2023
Merged
Fixing tests for #706 (backport #705)#735bmagyar merged 3 commits intoros-controls:mergify/bp/humble/pr-705from
bmagyar merged 3 commits intoros-controls:mergify/bp/humble/pr-705from
Conversation
bmagyar
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a segfault in #706 because fields from old message definition was used but subscribed to the new one.
Needs rclcpp 16.0.5, otherwise I got a problem with thread safety from the action tests.