[JTC] Add test for velocity error with effort cmd interface#690
Merged
bmagyar merged 4 commits intoros-controls:jtc-featuresfrom Jul 2, 2023
Merged
Conversation
…ve_ptr_ is nullptr (ros-controls#682)" This reverts commit 9ce288b.
(cherry picked from commit 2e0da5d)
bmagyar
approved these changes
Jul 2, 2023
This was referenced Jul 17, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 17, 2023
bmagyar
pushed a commit
that referenced
this pull request
Jul 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit ff6e81d)
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit ff6e81d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details see #679.
This needs to go into jtc-features, because parameterized tests for effort controllers are not activated on master yet.
I reverted #682 here, the segfault introduced there should be fixed directly on master before the merge of this one here IMHO.