Run workflow on feature branches#689
Merged
bmagyar merged 1 commit intoros-controls:jtc-featuresfrom Jun 28, 2023
Merged
Conversation
Member
|
Is this something we really need? Usually, maintainers can restart CI quite without problems, just opening the workflow. |
Member
Author
|
Now it would be handy with the jtc-features branch, because the PRs targeting into it aren't checked (can you manually run them on an arbitrary PR?). For this maybe the change of |
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 17, 2023
Member
|
Should we revert this, or do we want to merge those changes into master too? |
Member
Author
|
I vote for bringing this to master for other new feature branches in the future. |
bmagyar
pushed a commit
that referenced
this pull request
Jul 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit f70c986)
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit f70c986)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolling build workflows now should run on
workflow_dispatchandpull_requestevents on branches matching*feature*or*feature/**.These jobs fail now, because of #688