Fix file name for include guard#681
Merged
bmagyar merged 1 commit intoros-controls:masterfrom Jun 22, 2023
Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 35.78% 36.53% +0.75%
==========================================
Files 189 7 -182
Lines 17570 676 -16894
Branches 11592 357 -11235
==========================================
- Hits 6287 247 -6040
+ Misses 994 134 -860
+ Partials 10289 295 -9994
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
@bmagyar do you see more info why the ament_lint_cmake job failed? I can't access any docs. After |
bmagyar
approved these changes
Jun 22, 2023
Member
|
It was just flaky, happened a few times recently |
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
(cherry picked from commit c619aac)
bmagyar
pushed a commit
that referenced
this pull request
Aug 3, 2023
(cherry picked from commit c619aac) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
bmagyar
pushed a commit
that referenced
this pull request
Aug 5, 2023
* Fix file name for include guard (backport #681) (cherry picked from commit c619aac) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> * Activate AdmittanceControllerTestParameterizedInvalidParameters (#711) (#733) * [JTC] Re-enabling test, bugfixing and hardening. Adding a parameter to define when trajectories with non-zero velocity at the end are used. (backport #705) (#706) * Enable effort rejection test --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
bmagyar
pushed a commit
that referenced
this pull request
Aug 5, 2023
* Small improvement in remapping (#393) (#724) * Fix file name for include guard (backport #681) (cherry picked from commit c619aac) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> * Activate AdmittanceControllerTestParameterizedInvalidParameters (#711) (#733) * [JTC] Re-enabling test, bugfixing and hardening. Adding a parameter to define when trajectories with non-zero velocity at the end are used. (backport #705) (#706) * Add state_publish_rate parameter --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise cpplint complains
and the preprocessor macro cannot start with a number.