[JTC] Fix deprecated header#610
Merged
bmagyar merged 3 commits intoros-controls:masterfrom May 22, 2023
Merged
Conversation
bmagyar
approved these changes
May 13, 2023
Member
bmagyar
left a comment
There was a problem hiding this comment.
Sanity check: can't this go on master directly?
Member
Author
|
yes, why not!
Bence Magyar ***@***.***> schrieb am Sa., 13. Mai 2023, 10:38:
… ***@***.**** approved this pull request.
Sanity check: can't this go on master directly?
—
Reply to this email directly, view it on GitHub
<#610 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZWCTDG65DBUJLXOKDRN23XF5B7PANCNFSM6AAAAAAX7QZLIQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
==========================================
+ Coverage 35.78% 35.98% +0.20%
==========================================
Files 189 7 -182
Lines 17570 678 -16892
Branches 11592 362 -11230
==========================================
- Hits 6287 244 -6043
+ Misses 994 134 -860
+ Partials 10289 300 -9989
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mechwiz
pushed a commit
to mechwiz/ros2_controllers
that referenced
this pull request
Jul 3, 2023
This reverts commit 372725e.
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 25, 2023
This reverts commit 372725e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qos_event.hpp got deprecated:
See ros2/rclcpp#2069