Use system time in all tests to avoid error with different time sources.#334
Merged
bmagyar merged 1 commit intoros-controls:masterfrom Jul 24, 2022
Merged
Conversation
Member
|
There still seems to be errors... shouldn't this PR fix them? |
a534b81 to
0721025
Compare
bmagyar
approved these changes
Jul 24, 2022
Member
|
Only the joint_state_broadcaster tests fail on the CI ATM |
mamueluth
pushed a commit
to b-robotized-forks/ros2_controllers
that referenced
this pull request
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves (a new) issues caused by difference in time source (probably some changes in rclcpp cause that).
An example of the issue can be found here.