Skip to content

Remove deprecated gripper_controller#1652

Merged
christophfroehlich merged 8 commits intomasterfrom
rm/gripper_controller
May 17, 2025
Merged

Remove deprecated gripper_controller#1652
christophfroehlich merged 8 commits intomasterfrom
rm/gripper_controller

Conversation

@christophfroehlich
Copy link
Member

Got deprecated with #1002, and automatically resolves #223 ;)

@christophfroehlich christophfroehlich changed the base branch from master to add/kilted April 22, 2025 19:17
@christophfroehlich christophfroehlich added the hold Holding off merging this PR until some condition label Apr 22, 2025
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (945a360) to head (45a4576).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1652      +/-   ##
==========================================
+ Coverage   84.81%   85.60%   +0.78%     
==========================================
  Files         127      123       -4     
  Lines       12114    11873     -241     
  Branches     1036     1016      -20     
==========================================
- Hits        10275    10164     -111     
+ Misses       1501     1384     -117     
+ Partials      338      325      -13     
Flag Coverage Δ
unittests 85.60% <ø> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich changed the base branch from add/kilted to branch/jazzy April 22, 2025 19:52
@ros-controls ros-controls deleted a comment from mergify bot Apr 22, 2025
@christophfroehlich christophfroehlich deleted the branch master May 12, 2025 18:49
@github-project-automation github-project-automation bot moved this from Kilted to Done in Roadmap / Features May 12, 2025
@github-actions github-actions bot requested review from rosterloh and xguay May 16, 2025 15:14
@christophfroehlich christophfroehlich changed the base branch from branch/jazzy to master May 16, 2025 15:14
@mergify
Copy link
Contributor

mergify bot commented May 16, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich moved this from Done to Kilted in Roadmap / Features May 16, 2025
@mergify
Copy link
Contributor

mergify bot commented May 17, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich merged commit 0095ef1 into master May 17, 2025
24 of 28 checks passed
@christophfroehlich christophfroehlich deleted the rm/gripper_controller branch May 17, 2025 09:46
@github-project-automation github-project-automation bot moved this from Kilted to Done in Roadmap / Features May 17, 2025
vermaete added a commit to vermaete/meta-ros that referenced this pull request May 25, 2025
The gripper-controllers is removed from ros2_controllers
@see: ros-controls/ros2_controllers#1652

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
vermaete added a commit to vermaete/meta-ros that referenced this pull request May 30, 2025
The gripper-controllers is removed from ros2_controllers
@see: ros-controls/ros2_controllers#1652

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
vermaete added a commit to vermaete/meta-ros that referenced this pull request Jun 7, 2025
The gripper-controllers is removed from ros2_controllers
@see: ros-controls/ros2_controllers#1652

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
vermaete added a commit to vermaete/meta-ros that referenced this pull request Jun 9, 2025
The gripper-controllers is removed from ros2_controllers
@see: ros-controls/ros2_controllers#1652

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
vermaete added a commit to vermaete/meta-ros that referenced this pull request Jun 22, 2025
The gripper-controllers is removed from ros2_controllers
@see: ros-controls/ros2_controllers#1652

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
vermaete added a commit to vermaete/meta-ros that referenced this pull request Jun 22, 2025
Recipe is removed from ros.
see: ros-controls/ros2_controllers#1652

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
vermaete added a commit to vermaete/meta-ros that referenced this pull request Jul 6, 2025
Recipe is removed from ros.
see: ros-controls/ros2_controllers#1652

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
robwoolley pushed a commit to ros/meta-ros that referenced this pull request Jul 10, 2025
Recipe is removed from ros.
see: ros-controls/ros2_controllers#1652

Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Holding off merging this PR until some condition

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

position_controllers/GripperActionController is in gripper_controllers package?

2 participants