[JointTrajectoryController] Enable position, velocity and acceleration interfaces#140
[JointTrajectoryController] Enable position, velocity and acceleration interfaces#140bmagyar merged 10 commits intoros-controls:masterfrom
Conversation
|
We could have a similar approach to |
To keep this PR shorter I will add those into a separate one. Before merging we need to:
|
AndyZe
left a comment
There was a problem hiding this comment.
Reviewed a couple hundred lines... I'll come back for more later
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/test/test_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
040f077 to
325bdb6
Compare
|
OK, now I only have one two more test issues left:
Please help. |
bmagyar
left a comment
There was a problem hiding this comment.
the actual controller implementation looks good but I think we should reorganize things a bit to make the core more maintainable
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
…ell as after an unsuccessful configure call
…ails to configure, remain in UNCONFIGURED
this addresses #135 and it should replace #36.
Currently the only version with commented-out code to work with KUKA robots.
Proposal: we should choose between different versions using parameters.