Scope is up to you, a 500 line PR is a good chunk to review, feel free to open a better-scope follow-up ticket for what's left https://github.com/ros-controls/ros_controllers/tree/melodic-devel/joint_trajectory_controller/test