Skip to content

[CI] Use correct ref for scheduled workflows#1013

Merged
bmagyar merged 1 commit intoros-controls:masterfrom
christophfroehlich:ci_scheduled_wfs
Feb 5, 2024
Merged

[CI] Use correct ref for scheduled workflows#1013
bmagyar merged 1 commit intoros-controls:masterfrom
christophfroehlich:ci_scheduled_wfs

Conversation

@christophfroehlich
Copy link
Copy Markdown
Member

  • workflow schedules are (only) run from master branch
  • without giving an explicit ref argument the humble+iron workflows have checked out the master branch, which obviously fails
  • fixed now with this if-clause in the ref field

See also ros-controls/ros2_control#1361

Copy link
Copy Markdown
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bmagyar bmagyar merged commit 737a45b into ros-controls:master Feb 5, 2024
@christophfroehlich christophfroehlich deleted the ci_scheduled_wfs branch February 5, 2024 07:31
pac48 pushed a commit to pac48/ros2_controllers that referenced this pull request Feb 6, 2024
@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-iron labels Feb 7, 2024
mergify bot pushed a commit that referenced this pull request Feb 7, 2024
(cherry picked from commit 737a45b)

# Conflicts:
#	.github/workflows/humble-debian-build.yml
#	.github/workflows/humble-rhel-binary-build.yml
#	.github/workflows/iron-debian-build.yml
#	.github/workflows/iron-rhel-binary-build.yml
#	.github/workflows/rolling-debian-build.yml
#	.github/workflows/rolling-rhel-binary-build.yml
mergify bot pushed a commit that referenced this pull request Feb 7, 2024
(cherry picked from commit 737a45b)

# Conflicts:
#	.github/workflows/humble-debian-build.yml
#	.github/workflows/humble-rhel-binary-build.yml
#	.github/workflows/iron-debian-build.yml
#	.github/workflows/iron-rhel-binary-build.yml
#	.github/workflows/rolling-debian-build.yml
#	.github/workflows/rolling-rhel-binary-build.yml
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants