Skip to content

Inverse the response of cli commands to return correct exit-status.#308

Merged
bmagyar merged 2 commits intoros-controls:masterfrom
ShotaAk:master
Jan 28, 2021
Merged

Inverse the response of cli commands to return correct exit-status.#308
bmagyar merged 2 commits intoros-controls:masterfrom
ShotaAk:master

Conversation

@ShotaAk
Copy link
Copy Markdown
Contributor

@ShotaAk ShotaAk commented Jan 26, 2021

Fix #306 .

Copy link
Copy Markdown
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks @ShotaAk !

@destogl
Copy link
Copy Markdown
Member

destogl commented Jan 26, 2021

@ShotaAk could you also extend this functionality to other verbs also? So that each verb returns success/failure values.

@ShotaAk
Copy link
Copy Markdown
Contributor Author

ShotaAk commented Jan 26, 2021

@destogl Do you mean list* verbs right?
Since there are no response ok in List*.srv files, I will insert return 0 to each list verbs. Is it OK?

@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Jan 28, 2021

Thanks for the contribution @ShotaAk !

@bmagyar bmagyar merged commit 654c51d into ros-controls:master Jan 28, 2021
mahaarbo pushed a commit to mahaarbo/ros2_control that referenced this pull request Feb 4, 2021
…os-controls#308)

* Inverse the response of cli commands to return correct exit-status.

* list verbs return exit-status 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some cli commands return '1' even through it's successfully executed

3 participants