Skip to content

Remove old joint state and joint command handles#134

Merged
bmagyar merged 2 commits intoros-controls:masterfrom
pal-robotics-forks:remove_old_handles
Sep 16, 2020
Merged

Remove old joint state and joint command handles#134
bmagyar merged 2 commits intoros-controls:masterfrom
pal-robotics-forks:remove_old_handles

Conversation

@jordan-palacios
Copy link
Copy Markdown
Member

@jordan-palacios jordan-palacios commented Aug 24, 2020

Remove all trace to hardware_interface::JointStateHandle and hardware_interface::JointCommandHandle.

Requires #125 and ros-controls/ros2_controllers#90.

Closes #125.

@jordan-palacios jordan-palacios mentioned this pull request Aug 24, 2020
Closed
4 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 24, 2020 •
edited
Loading

Codecov Report

Merging #134 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   37.25%   36.61%   -0.64%     
==========================================
  Files          44       42       -2     
  Lines        1863     1726     -137     
  Branches     1136     1080      -56     
==========================================
- Hits          694      632      -62     
+ Misses        130      100      -30     
+ Partials     1039      994      -45
Flag Coverage Δ
#unittests 36.61% <ø> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...face/include/hardware_interface/robot_hardware.hpp 50.00% <ø> (ø)
hardware_interface/src/robot_hardware.cpp 53.84% <ø> (-0.10%) ⬇️
...e_interface/test/test_robot_hardware_interface.cpp 53.48% <ø> (+6.50%) ⬆️
test_robot_hardware/src/test_robot_hardware.cpp 31.74% <ø> (-3.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3aad1...1bacac0. Read the comment docs.

@jordan-palacios jordan-palacios force-pushed the remove_old_handles branch 2 times, most recently from 250cf43 to cd60339 Compare September 2, 2020 16:27
@destogl destogl mentioned this pull request Sep 9, 2020
Closed
@destogl
Copy link
Copy Markdown
Member

destogl commented Sep 10, 2020

@jordan-palacios do you need this for ros-controls/ros2_controllers#90? Is this ready for review?

@bmagyar @Karsten1987 I would propose to merge this one and then start porting to new Joint and Sensor components from #121. In this way, we would have smaller PRs and can track changes easily.

@jordan-palacios
Copy link
Copy Markdown
Member Author

jordan-palacios commented Sep 10, 2020

@jordan-palacios do you need this for ros-controls/ros2_controllers#90? Is this ready for review?

Yes. As soon as ros-controls/ros2_controllers#90 is merged. You can review it meanwhile if you like.

@jordan-palacios jordan-palacios marked this pull request as ready for review September 15, 2020 07:37
@bmagyar bmagyar merged commit 9a25721 into ros-controls:master Sep 16, 2020
@ShotaAk ShotaAk mentioned this pull request Sep 17, 2020
Closed
@jordan-palacios jordan-palacios deleted the remove_old_handles branch September 17, 2020 08:17
@destogl destogl mentioned this pull request Sep 20, 2020
Closed
This was referenced Oct 4, 2020
Merged
Merged
@bmagyar bmagyar mentioned this pull request Oct 10, 2020
Closed
@bostoncleek bostoncleek mentioned this pull request Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmagyar bmagyar bmagyar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jordan-palacios @codecov-commenter @destogl @bmagyar