Merged
Conversation
4 tasks
7ec24f2 to
8d72b25
Compare
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 45.85% 43.32% -2.53%
==========================================
Files 38 42 +4
Lines 1230 1424 +194
Branches 648 786 +138
==========================================
+ Hits 564 617 +53
- Misses 72 85 +13
- Partials 594 722 +128
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
90f5649 to
24f4809
Compare
Member
|
this is a good transition PR for the Joint/Sensor components. I agree to go on with this. |
b3c05c0 to
f325134
Compare
This was referenced Aug 24, 2020
…namicJointState message
f325134 to
34f8e64
Compare
Karsten1987
approved these changes
Aug 24, 2020
| { | ||
| SetUpHandles(); | ||
| EXPECT_THAT(robot_.get_registered_joint_names(), ElementsAre(JOINT_NAME)); | ||
| // EXPECT_THAT(robot_.get_registered_joint_names(), ElementsAre(JOINT_NAME)); |
Contributor
There was a problem hiding this comment.
What's the status of these tests?
Member
Author
There was a problem hiding this comment.
They only test the OperationModeHandle. The joint handles tests are now in test_joint_handle.cpp and test_register_joints.cpp.
Contributor
|
With #121 being merged, is this going to be reworked to use the same |
bmagyar
approved these changes
Aug 28, 2020
destogl
pushed a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to add a new type of joint handle and the interfaces to handle them. They are intended to replace
JointStateHandleandJointCommandHandleeventually. For the duration of this PR, however, they will coexist.See #124 for more information.