Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 70.12% 71.67% +1.55%
==========================================
Files 8 9 +1
Lines 492 519 +27
Branches 84 85 +1
==========================================
+ Hits 345 372 +27
Misses 92 92
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
TBH, I don't fully understand all the C++ specifics here 😬
But the API seems to be clean from a user perspective, looking at the tests.
- Does this replace the RealtimeBuffer? Or should the RealtimeBuffer be rewritten to use this queue with capacity of 1?
- What is the practical difference between the RealtimeBox and the queue with capacity of 1? Maybe this is clear for some, but I'd need (and appreciate) a user guide when to use what.
- If we deprecate something, we can also add migration notes to this repository and link it on control.ros.org
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich
previously approved these changes
Jan 9, 2025
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
I tested that with ros-controls/ros2_controllers#1480, the API works for me!
Member
Author
@christophfroehlich I had to rewrite some parts of tests to reuse rather than copying for every instance. I've add more tests for all constructable types |
bmagyar
reviewed
Jan 15, 2025
bmagyar
approved these changes
Jan 29, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
(cherry picked from commit 1d66fed)
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
(cherry picked from commit 1d66fed)
This was referenced Jan 29, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Jan 29, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14