Skip to content

use std::stof#49

Closed
Karsten1987 wants to merge 1 commit intoros:masterfrom
Karsten1987:use_stof
Closed

use std::stof#49
Karsten1987 wants to merge 1 commit intoros:masterfrom
Karsten1987:use_stof

Conversation

@Karsten1987
Copy link
Copy Markdown

fixes a warning we currently see on the ROS 2 buildfarm for windows.

@Karsten1987 Karsten1987 mentioned this pull request Nov 15, 2018
@Karsten1987
Copy link
Copy Markdown
Author

duplicate of #48

@clalancette
Copy link
Copy Markdown
Contributor

We just removed std::stof in f97cbce :). It doesn't work across locales, which is why we switched to the strToDouble helper, which does.

@Karsten1987
Copy link
Copy Markdown
Author

understood :) Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants