Skip to content

Cast double to float#48

Merged
scpeters merged 1 commit intomasterfrom
sloretz-patch-1
Nov 15, 2018
Merged

Cast double to float#48
scpeters merged 1 commit intomasterfrom
sloretz-patch-1

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Nov 14, 2018

This is an attempt to fix a warning on windows. See comment https://github.com/ros/urdfdom_headers/pull/47/files#r233640215

@sloretz sloretz added the bug label Nov 14, 2018
@sloretz sloretz self-assigned this Nov 14, 2018
@sloretz sloretz requested a review from clalancette November 14, 2018 22:18
@sloretz sloretz mentioned this pull request Nov 14, 2018
Merged
clalancette
clalancette reviewed Nov 14, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll request a clean Windows build so we can know for sure it is fixed :).

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 14, 2018

@clalancette rebuilding with the same packaging job that showed the warnings in the first place Build Status

@Karsten1987
Copy link
Copy Markdown

Karsten1987 commented Nov 15, 2018

what about using std::stof? #49
I just saw that my PR came in after this one, so I am happy to close it again.

This was referenced Nov 15, 2018
Closed
Merged
@scpeters
Copy link
Copy Markdown
Contributor

scpeters commented Nov 15, 2018

I'm also setting up an appveyor build for urdfdom so we should get more frequent windows CI testing

Once I have the build working, I'll make a PR and ask @tfoote to add the appveyor webhook

@scpeters
Copy link
Copy Markdown
Contributor

scpeters commented Nov 15, 2018

@sloretz it looks like there's still warnings in that CI build?

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 15, 2018

Ah ooops, I ran CI using urdfdom_headers from master. I'll re-run CI

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 15, 2018

CI using correct branch Build Status

@scpeters
Copy link
Copy Markdown
Contributor

scpeters commented Nov 15, 2018

@sloretz that build failed

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 15, 2018

The build failure should be fixed by ament/ament_lint#115

New CI Build Status

@scpeters scpeters merged commit 5762580 into master Nov 15, 2018
@scpeters scpeters deleted the sloretz-patch-1 branch November 15, 2018 21:51
@clalancette clalancette mentioned this pull request Nov 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette left review comments

@scpeters scpeters scpeters approved these changes

Assignees

@sloretz sloretz

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sloretz @Karsten1987 @scpeters @clalancette