Added optional package.xml for use with doc jobs and optional catkin building#2
Closed
davetcoleman wants to merge 2 commits intoros:masterfrom
Closed
Added optional package.xml for use with doc jobs and optional catkin building#2davetcoleman wants to merge 2 commits intoros:masterfrom
davetcoleman wants to merge 2 commits intoros:masterfrom
Conversation
Contributor
|
The package.xml is added automatically by bloom in the release repo. There should be no package.xml here. |
|
@davetcoleman See ros/rosdistro#1721 (comment), I was misspoken earlier this evening, apparently, we can use the package.xml that was added in the bloom repository. |
Karsten1987
pushed a commit
to Karsten1987/urdfdom
that referenced
this pull request
Nov 15, 2018
add visual and collision names
clalancette
pushed a commit
that referenced
this pull request
Oct 16, 2020
* find debug libraries correctly * cleanup cmake file. remove messages * set optimized/debug keywords correctly in place * style
clalancette
pushed a commit
that referenced
this pull request
Jun 30, 2021
* find debug libraries correctly * cleanup cmake file. remove messages * set optimized/debug keywords correctly in place * style
clalancette
pushed a commit
that referenced
this pull request
Jul 6, 2021
* find debug libraries correctly * cleanup cmake file. remove messages * set optimized/debug keywords correctly in place * style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its my understanding that you can add a package.xml to non-ROS packages to allow optional catkin building and to allow hydro/doc.yaml to parse the package. Does this work? @tfoote @isucan