[urdf_parser_py] Python3 compatibility#19
Merged
isucan merged 1 commit intoros:masterfrom Dec 17, 2013
Merged
Conversation
Contributor
|
My knowledge of Python is reduced. Does this still work with Python2? Has it been tested? |
There was a problem hiding this comment.
This script needs "from future import print_function" to maintain 2.7 compat.
Author
|
I have of course tested with python2 as well. And no, it does not require to import from future (at least if python2.6 and python2.7 are enough for you). |
|
Huh, you're right, I didn't realize that about print_function and 2.6/7 Otherwise looks good to me, although it appears we don't have much of a test suite for the python package, how did you test it @severin-lemaignan ? |
Author
|
Checking the diff of the output of |
isucan
added a commit
that referenced
this pull request
Dec 17, 2013
[urdf_parser_py] Python3 compatibility
Merged
Karsten1987
pushed a commit
to Karsten1987/urdfdom
that referenced
this pull request
Nov 15, 2018
Fix handling rpy with pitch equal to +/-M_PI/2
clalancette
pushed a commit
that referenced
this pull request
Oct 16, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Jun 30, 2021
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Jul 6, 2021
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.