Skip to content

Update tbb entry for NixOS#48172

Merged
emersonknapp merged 1 commit intoros:masterfrom
wentasah:nixos-tbb
Oct 17, 2025
Merged

Update tbb entry for NixOS#48172
emersonknapp merged 1 commit intoros:masterfrom
wentasah:nixos-tbb

Conversation

@wentasah
Copy link
Copy Markdown
Contributor

tbb_* was renamed to onetbb. See NixOS/nixpkgs#442977.

tbb_2021_11, which was used in rosdep before has been replaced by tbb_2021 earlier in NixOS/nixpkgs#402480.

tbb_* was renamed to onetbb.
See NixOS/nixpkgs#442977.

tbb_2021_11, which was used in rosdep before has been replaced by
tbb_2021 earlier in NixOS/nixpkgs#402480.

Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
@wentasah wentasah requested a review from a team as a code owner October 16, 2025 18:11
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Oct 16, 2025
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ✅ Platforms for new rosdep rules are valid

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

wentasah added a commit to wentasah/nix-ros-overlay that referenced this pull request Oct 16, 2025
This is needed with currently used nixpkgs version. Later, this should
be fixed in rosdep, where we will use the new version-indepenent name
onetbb (ros/rosdistro#48172).
wentasah added a commit to wentasah/nix-ros-overlay that referenced this pull request Oct 16, 2025
This is needed with currently used nixpkgs version. Later, this should
be fixed in rosdep, where we will use the new version-indepenent name
onetbb (ros/rosdistro#48172).
wentasah added a commit to lopsided98/nix-ros-overlay that referenced this pull request Oct 16, 2025
This is needed with currently used nixpkgs version. Later, this should
be fixed in rosdep, where we will use the new version-indepenent name
onetbb (ros/rosdistro#48172).
@mjcarroll mjcarroll added the rosdep-needs-second-approval rosdep key PR is waiting for a 2nd approval label Oct 16, 2025
@emersonknapp emersonknapp merged commit 0ecac34 into ros:master Oct 17, 2025
5 checks passed
wentasah added a commit to lopsided98/nix-ros-overlay that referenced this pull request Oct 17, 2025
My rosdep PR ros/rosdistro#48172 was merged
faster than I expected :-)
wentasah added a commit to wentasah/nix-ros-overlay that referenced this pull request Oct 17, 2025
My rosdep PR ros/rosdistro#48172 was merged
faster than I expected :-)
wentasah added a commit to lopsided98/nix-ros-overlay that referenced this pull request Oct 19, 2025
My rosdep PR ros/rosdistro#48172 was merged
faster than I expected :-)
wentasah added a commit to wentasah/nix-ros-overlay that referenced this pull request Oct 30, 2025
In recent nixpkgs, all tbb_* versions were renamed to a single onetbb
package: NixOS/nixpkgs#442977. This change was
reflected in rosdep (ros/rosdistro#48172) and
merged pretty quickly, definitely faster than we'll be able to switch
master branch to the new nixpkgs version (we need to solve all Qt5
problems before).

Therefore, we add this alias so that people using recent rosdep (e.g.
via ros2nix) with the master branch do not end up with broken
derivations.
wentasah added a commit to wentasah/nix-ros-overlay that referenced this pull request Oct 30, 2025
In recent nixpkgs, all tbb_* versions were renamed to a single onetbb
package: NixOS/nixpkgs#442977. This change was
reflected in rosdep (ros/rosdistro#48172) and
merged pretty quickly, definitely faster than we'll be able to switch
master branch to the new nixpkgs version (we need to solve all Qt5
problems before).

Therefore, we add this alias so that people using recent rosdep (e.g.
via ros2nix) with the master branch do not end up with broken
derivations.
wentasah added a commit to wentasah/nix-ros-overlay that referenced this pull request Oct 30, 2025
In recent nixpkgs, all tbb_* versions were renamed to a single onetbb
package: NixOS/nixpkgs#442977. This change was
reflected in rosdep (ros/rosdistro#48172) and
merged pretty quickly, definitely faster than we'll be able to switch
master branch to the new nixpkgs version (we need to solve all Qt5
problems before).

Therefore, we add this alias so that people using recent rosdep (e.g.
via ros2nix) with the master branch do not end up with broken
derivations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rosdep Issue/PR is for a rosdep key rosdep-needs-second-approval rosdep key PR is waiting for a 2nd approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants