rtabmap/rtabmap_ros: 0.20.18-1 in 'melodic/distribution.yaml'#31952
rtabmap/rtabmap_ros: 0.20.18-1 in 'melodic/distribution.yaml'#31952mabelzhang merged 1 commit intoros:masterfrom matlabbe:patch-32
Conversation
Increasing version of package(s) in repository `rtabmap` `rtabmap_ros` to `0.20.18-1`: - upstream repository: https://github.com/introlab/rtabmap.git, https://github.com/introlab/rtabmap_ros.git - release repository: https://github.com/introlab/rtabmap-release.git, https://github.com/introlab/rtabmap_ros-release.git - distro file: `melodic/distribution.yaml`
|
I clicked merge too soon. This is releasing 2 packages and was not opened via Bloom. What's the reason this wasn't done via Bloom? |
|
I cannot release them by bloom at the same time (well I use bloom to make the release packages but stop before opening a pull request from bloom), otherwise you would have to make sure to merge in right order. rtabmap_ros package depends on rtabmap package, if rtabmap_ros pull request would be merged before rtabmap pull request, the first rtabmap_ros build would fail by default until rtabmap pull request is merged. However, if failing one time is not that a problem for you, I could send them separatly directly from bloom. I was planning to do foxy and galactic releases today, I'll do them separatly to see what it would do (I'll will add a comment after the pull requests for the right merge order). |
|
I would simply comment in the PR that it's not to be merged before PR such-and-such. I think they would adhere to that. And if not, it would just be a couple of broken builds until the dependency is merged, so not even that bad! |
|
Yeah, we can follow the merge order if you tag the dependent PR. Thanks! |
Increasing version of package(s) in repository
rtabmaprtabmap_rosto0.20.18-1:melodic/distribution.yaml