Change robot_model from indigo-devel branch to jade-devel tag#15927
Merged
sloretz merged 1 commit intoros:masterfrom Sep 15, 2017
sloretz:freeze_robot_model_jade
Merged
Change robot_model from indigo-devel branch to jade-devel tag#15927sloretz merged 1 commit intoros:masterfrom sloretz:freeze_robot_model_jade
sloretz merged 1 commit intoros:masterfrom
sloretz:freeze_robot_model_jade
Conversation
Member
|
looks good to me, thanks for the follow-up |
Member
|
Note that the job will fail because we dont allow modifications in eol distros, but it's ok to merge anyway |
Contributor
Author
|
Note to future self, this failed because the source entry must be a branch and not a tag (thanks @dirk-thomas). I'll delete the jade-devel tag on robot_model and make it a branch. |
Contributor
Author
|
Failed with only the expected failure: so I'm going to squash/merge this. |
This was referenced Sep 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this is to not break
rosinstall_generator --upstream-developmentfor the EOL distro jade once the packagejoint_state_publisheris removed from theindigo-develbranch. This changes the version for the repositoryrobot_modelfrom the branchindigo-develto a tagjade-devel. The tag is set to the state of the repo when the last jade sync happened.See #15926
See ros/robot_model#195