You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks good to me.
Before removing the package from the robot_model source repo, it may be worth checking downstream packages to make sure nobody relies on the previous URI like it happened when we started moving robot model packages
@mikaelarguedas good idea. Looks like this is in the clear. I checked two levels down using the ros wiki Used by. All were on github so I searched for joint_state_publisher and robot_model. Nothing looking like a URL came up.
sloretz
changed the title
Move joint_state_publisher from robot_model to it's own repository (indigo)
Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic)
Sep 15, 2017
sloretz
changed the title
Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic)
[WIP] Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic)
Sep 15, 2017
sloretz
changed the title
[WIP] Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic)
[WIP] Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic/lunar)
Sep 15, 2017
sloretz
changed the title
[WIP] Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic/lunar)
Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic/lunar)
Sep 15, 2017
@sloretz@clalancette I just noticed something fishy with EOL distros:
All distros before indigo are fine because they had their own branchs that stayed unmodified and still have all the packages in them.
Now that Jade became EOL it's a bit trickier because it uses the indigo-devel branch like indigo but that branch doesn't have the packages anymore so people cannot build them from source anymore.
Speaking with @tfoote the best way to go would be to create a tag jade-devel on the robot-model repo with the state of the repo before Jade became EOL and update the Jade disctibution file to point to that new tag rather than the indigo-devel branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of ros/robot_model#195
To indigo this releases 1.11.15-0
To kinetic/lunar this releases 1.12.12-0
This moves joint_state_publisher out of the robot_model repository. Bloom was used up to the point of creating this pull request.