Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Add timestamp formatting for rosconsole#22

Merged
dirk-thomas merged 2 commits intoros:noetic-develfrom
abrzozowski:melodic-devel
Apr 7, 2020
Merged

Add timestamp formatting for rosconsole#22
dirk-thomas merged 2 commits intoros:noetic-develfrom
abrzozowski:melodic-devel

Conversation

@abrzozowski
Copy link
Copy Markdown
Contributor

@abrzozowski abrzozowski commented Nov 18, 2018

It's Cpp part of formatter Based on PR ros/ros_comm#1458 from ros_comm. Related to the ros/ros_comm#1533 for Python.

@dirk-thomas
Copy link
Copy Markdown
Member

Please retarget the current default branch noetic-devel and rebase your branch.

@abrzozowski
Copy link
Copy Markdown
Contributor Author

abrzozowski commented Feb 29, 2020

I rebased my branch on top of ros:melodic-devel. Repository https://github.com/ros/rosconsole doesn't have a noetic-devel branch.

@abrzozowski
Copy link
Copy Markdown
Contributor Author

@dirk-thomas Could you tell me, what should I do with this PR?

@dirk-thomas dirk-thomas changed the base branch from melodic-devel to noetic-devel April 7, 2020 01:21
@dirk-thomas
Copy link
Copy Markdown
Member

I just got around to create a noetic-devel branch, updated some indentation in e98e35d and will go ahead merging this,

Thanks for the improvement.

@dirk-thomas dirk-thomas merged commit f71e2f0 into ros:noetic-devel Apr 7, 2020
@abrzozowski
Copy link
Copy Markdown
Contributor Author

Added description in the ROS wiki: http://wiki.ros.org/action/diff/rosconsole?action=diff&rev1=74&rev2=75

@kakaday22
Copy link
Copy Markdown

Any possibility to have this enhancement done on Ros Melodic?

SyaffKun pushed a commit to dfautomation/rosconsole that referenced this pull request Apr 13, 2024
* Add timestamp formatting for rosconsole

* update indentation

Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants