Skip to content

Use get_package_share_path#193

Merged
ahcorde merged 2 commits intorollingfrom
ahcorde/rolling/get_package_share_path
Feb 25, 2026
Merged

Use get_package_share_path#193
ahcorde merged 2 commits intorollingfrom
ahcorde/rolling/get_package_share_path

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Feb 24, 2026

Related with ament/ament_index#112

FYI @Timple

@ahcorde
Use get_package_share_path
7bec0f3 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Feb 24, 2026
This was referenced Feb 24, 2026
Merged
Merged
Merged
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Feb 24, 2026

Pulls: ament/ament_index#112, ros2/rmw_zenoh#913, ros2/rviz#1671, ros/resource_retriever#119, #193, ros-perception/image_common#391
Gist: https://gist.githubusercontent.com/ahcorde/4443a34cc7425a61b630b0ea7761d778/raw/ee918bf6abee19d2c84b4f3502bc35f27436183a/ros2.repos
BUILD args: --packages-above-and-dependencies ament_index_cpp
TEST args: --packages-above ament_index_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18300

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Feb 24, 2026
Merged
Merged
Timple
Timple reviewed Feb 24, 2026
View reviewed changes
turtlesim/include/turtlesim/turtle_frame.hpp Outdated
#include <string>
#include <rclcpp/rclcpp.hpp>
#include <ament_index_cpp/get_package_share_directory.hpp>
#include <ament_index_cpp/get_package_share_path.hpp>
Copy link
Copy Markdown

@Timple Timple Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be included in the .cpp as it's not used in the header.

@ahcorde
review feedback
09c2567 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Feb 24, 2026

Pulls: ament/ament_index#112, ros2/rmw_zenoh#913, ros2/rviz#1671, ros/resource_retriever#119, #193, ros-perception/image_common#391
Gist: https://gist.githubusercontent.com/ahcorde/fbb27b2127b62cdf0c2dea03ea0b3fec/raw/ee918bf6abee19d2c84b4f3502bc35f27436183a/ros2.repos
BUILD args: --packages-above-and-dependencies ament_index_cpp
TEST args: --packages-above ament_index_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18301

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit b5b50f1 into rolling Feb 25, 2026
2 of 3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/get_package_share_path branch February 25, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Timple Timple Timple approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahcorde @Timple