This repository was archived by the owner on May 31, 2025. It is now read-only.
fixed UDP block number when EAGAIN or EWOULDBLOCK#957
Merged
jspricke merged 3 commits intoros:kinetic-develfrom Jan 16, 2017
Merged
fixed UDP block number when EAGAIN or EWOULDBLOCK#957jspricke merged 3 commits intoros:kinetic-develfrom
jspricke merged 3 commits intoros:kinetic-develfrom
Conversation
Member
|
+1, but could you remove the unrelated whitespace changes from the patch? |
reverted unnecessary whitespace changes
Member
|
Thx! |
ggallagher01
pushed a commit
to clearpathrobotics/ros_comm
that referenced
this pull request
Jan 26, 2017
* fixed UDP block number when EAGAIN or EWOULDBLOCK
dirk-thomas
pushed a commit
that referenced
this pull request
Mar 2, 2017
* fixed UDP block number when EAGAIN or EWOULDBLOCK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug in
TransportUDP::write. When this branch is taken,num_bytesis initialized to retry the write operation. However,this_blockstays increased. This causes block number in the datagram head to increase to an arbitrary amount, and the subscriber cannot receive the expected block. This commit just decreasesthis_blockand retry the write properly.