This repository was archived by the owner on May 31, 2025. It is now read-only.
In write_header() use poll if available.#929
Merged
dirk-thomas merged 1 commit intoros:kinetic-develfrom Feb 8, 2017
Merged
Conversation
mikepurvis
reviewed
Nov 10, 2016
| _, ready, _ = select.select([], [fileno], []) | ||
| except ValueError as e: | ||
| logger.error("[%s]: select fileno '%s': %s", self.name, str(fileno), str(e)) | ||
| raise e |
Member
There was a problem hiding this comment.
I believe you can just raise and it will automatically re-raise the current exception.
Member
|
Looks good to me. 👍 |
We are hitting the select bug where fileno > 1023 causing an "out of range" error. Changing the select to a poll where available to support higher numbered fileno.
078f999 to
0438fdd
Compare
Contributor
Author
|
ping @tfoote @dirk-thomas |
Member
|
Looks like this is a similar kind of change to what's going on in #833. @mgrrx, can you comment? Am curious to better understand the relationship between this code and the ros_comm/clients/rospy/src/rospy/topics.py Line 185 in 6742631 |
mikepurvis
added a commit
to clearpathrobotics/ros_comm
that referenced
this pull request
Jan 31, 2017
mikepurvis
added a commit
that referenced
this pull request
Jan 31, 2017
mikepurvis
added a commit
that referenced
this pull request
Jan 31, 2017
Member
|
Just a though: the code path if |
mikepurvis
added a commit
that referenced
this pull request
Feb 7, 2017
mikepurvis
added a commit
that referenced
this pull request
Feb 7, 2017
mikepurvis
added a commit
that referenced
this pull request
Feb 7, 2017
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
In write_header() use poll if available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are hitting the select bug where fileno > 1023
causing an "out of range" error. Changing the select to a
poll where available to support higher numbered fileno.