This repository was archived by the owner on May 31, 2025. It is now read-only.
Fix BagMigrationException in migrate_raw#917
Merged
dirk-thomas merged 1 commit intoros:kinetic-develfrom Oct 26, 2016
Merged
Conversation
Take the ._type using [0], because the arguments passed to migrate_raw are tuples. This was throwing another exception because of that bug: AttributeError, saying that tuple has no attribute _type.
Contributor
Author
|
I've tested the fixed, and now I see the proper exception being thrown. 😃 Migrate called, but no valid migration path from [my_msgs/Message] to [my_msgs/Message] |
Contributor
Author
Member
|
Thank you. |
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
Fix BagMigrationException in migrate_raw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the
._typeusing[0], because the arguments passed tomigrate_raware tuples.This was throwing another exception because of that bug:
AttributeError, saying that tuple has no attribute_type: