This repository was archived by the owner on May 31, 2025. It is now read-only.
[rospy] raise error on rospy.init_node with None or empty node name string#895
Closed
furushchev wants to merge 2 commits intoros:indigo-develfrom
Closed
[rospy] raise error on rospy.init_node with None or empty node name string#895furushchev wants to merge 2 commits intoros:indigo-develfrom
furushchev wants to merge 2 commits intoros:indigo-develfrom
Conversation
…ith None or empty node name string
dirk-thomas
pushed a commit
that referenced
this pull request
Sep 14, 2016
Member
|
Thank you for the improvement. I have cherry picked the changes to the kinetic-devel branch: bd3af70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
according to the discussion at #891
current rospy shows warning if node name is empty string, so this pull request ensures the empty string for node name on initialization is invalid with raising error.