This repository was archived by the owner on May 31, 2025. It is now read-only.
Added missing arg to check_roslaunch_dir() definition#890
Merged
dirk-thomas merged 2 commits intoros:kinetic-develfrom Sep 7, 2016
Merged
Conversation
Member
|
Good catch. Can you please update the diff to only contain the changes compared to the kinetic-devel branch. Currently it seems to include many changes which have already been merged. |
Contributor
Author
Just noticed that as well; will do. |
| return "[%s]:\n\t%s"%(roslaunch_file,error_msg) | ||
|
|
||
| def check_roslaunch_dir(roslaunch_dir): | ||
| def check_roslaunch_dir(roslaunch_dir, use_test_depends=False): |
Member
There was a problem hiding this comment.
The parameter also needs to be passed to the check_roslaunch_file call in line 57.
Contributor
Author
There was a problem hiding this comment.
Got it, good catch.
Merged with upstream
364c363 to
44364bf
Compare
Member
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
* Added missing arg to check_roslaunch_dir() definition * Added use_test_depends arg to check_roslaunch_file() call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rosrun roslaunch roslaunch-check /path/to/filefails on kinetic-devel with the following output:It seems the new arg was added to the call, but not the method definition, in this diff.