This repository was archived by the owner on May 31, 2025. It is now read-only.
[rostopic] Show topic field type with rostopic type#860
Merged
dirk-thomas merged 5 commits intoros:indigo-develfrom Aug 25, 2016
Merged
[rostopic] Show topic field type with rostopic type#860dirk-thomas merged 5 commits intoros:indigo-develfrom
dirk-thomas merged 5 commits intoros:indigo-develfrom
Conversation
800d8bf to
fe6d8b2
Compare
As shown below: ```bash % rostopic type /raw_image_bgr/image_color/foo unknown topic type [/raw_image_bgr/image_color/foo] % rostopic type /raw_image_bgr/image_color/header sensor_msgs/Image header std_msgs/Header % rostopic type /raw_image_bgr/image_color/header/frame_id sensor_msgs/Image header/frame_id string % rostopic type /raw_image_bgr/image_color sensor_msgs/Image ```
Member
|
Can you please add a unit test for the new feature. |
Contributor
Author
|
I added tests |
| _rostopic_type(_optparse_topic_only('type', argv)) | ||
|
|
||
| args = argv[2:] | ||
| from optparse import OptionParser |
Member
There was a problem hiding this comment.
Please keep imports at the top of the module.
Contributor
Author
|
Fixed. |
| _rostopic_type(_optparse_topic_only('type', argv)) | ||
|
|
||
| parser = argparse.ArgumentParser(prog='%s type' % NAME) | ||
| parser.add_argument('topic_or_field', help='Topic or filed name') |
Contributor
Author
|
Fixed. |
Member
|
Thank you for these improvements to |
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 25, 2016
As shown below: ```bash % rostopic type /raw_image_bgr/image_color/foo unknown topic type [/raw_image_bgr/image_color/foo] % rostopic type /raw_image_bgr/image_color/header sensor_msgs/Image header std_msgs/Header % rostopic type /raw_image_bgr/image_color/header/frame_id sensor_msgs/Image header/frame_id string % rostopic type /raw_image_bgr/image_color sensor_msgs/Image ```
Member
|
I just realized that this was against indigo-devel. I reverted the commit and instead cherry-picked it to the kinetic-devel branch: c37a71c |
Contributor
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For jsk-ros-pkg/jsk_visualization#625 (comment)
As shown below:
The current behavior is below: