This repository was archived by the owner on May 31, 2025. It is now read-only.
roslaunch: Fix <param command="..." /> for python3.#840
Merged
dirk-thomas merged 1 commit intoros:kinetic-develfrom Jul 22, 2016
fizyr-private:roslaunch-param-command-python3
Merged
roslaunch: Fix <param command="..." /> for python3.#840dirk-thomas merged 1 commit intoros:kinetic-develfrom fizyr-private:roslaunch-param-command-python3
dirk-thomas merged 1 commit intoros:kinetic-develfrom
fizyr-private:roslaunch-param-command-python3
Conversation
In python3, the standard output of the subprocess is of type bytes. That causes the data to be stored as a binary xmlrpc node which ends up base64 encoded when retrieving it later. Additionally, it crashed the rosparam command line utility which could not deal with that. This commit checks if the read command output is not of type `str` and decodes it as UTF-8 in that case. This is a NOP in python2. We can't check if the read output is of type bytes, because in python2 `bytes` is just an alias for `str`.
Member
|
Thank you for the patch. |
Contributor
Author
|
Thanks for the merge :) |
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
…-python3 roslaunch: Fix <param command="..." /> for python3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In python3, the standard output of the subprocess is of type bytes. That causes the data to be stored as a binary xmlrpc node which ends up base64 encoded when retrieving it later. Additionally, it crashed the
rosparamcommand line utility which could not deal with that.This PR checks if the read command output is not of type
strand decodes it as UTF-8 in that case. This is a NOP in python2. We can't check if the read output is of type bytes, because in python2bytesis just an alias forstr.