This repository was archived by the owner on May 31, 2025. It is now read-only.
rosbag_storage: make Bag constructor explicit#835
Merged
dirk-thomas merged 1 commit intoros:kinetic-develfrom Aug 8, 2016
Merged
rosbag_storage: make Bag constructor explicit#835dirk-thomas merged 1 commit intoros:kinetic-develfrom
dirk-thomas merged 1 commit intoros:kinetic-develfrom
Conversation
This catches common mistakes such as view.addQuery(bagFileName, ...) Signed-off-by: Max Schwarz <max.schwarz@uni-bonn.de>
Member
|
Thank you for the patch. |
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
rosbag_storage: make Bag constructor explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small improvement to the rosbag API (adds "explicit" to the bag constructor)
Previously, it was possible to do something like this:
Note that bagFile is passed to View::addQuery, which does not cause a compiler error, since implicit conversion is allowed by the constructor. Using the view will cause a segfault, since the temporary bag will no longer be around.
I think that there are no good use cases for implicit std::string -> rosbag::Bag conversions, so we should disallow them.