Conversation
|
Is this the only place an XMLRPC server is created in Python? Do nodes in |
|
Yeah there are some other uses of XML-RPC, but I thought it might be more tractable to go after them one at a time (?) |
|
That's fine, so long as you're aware that this isn't the only place. |
|
I could be wrong, but looking at the CI logs, I'm guessing that #780 might be (independently) fixing the test that failed here? |
|
@ros-pull-request-builder retest this please |
|
#780 is only proposing a new test so it can't affect the results of other tests. The tests which failed in the last CI run are timing dependent and sadly flaky. I triggered another run already. |
|
Ah, thank you @dirk-thomas for explaining and re-triggering the test. |
|
@ros-pull-request-builder retest this please |
1 similar comment
|
@ros-pull-request-builder retest this please |
|
I can't seem to get this to pass test_random_play, and since #783 is failing as well, I'm wondering if it's not due to this PR (?) 🐔 |
|
@ros-pull-request-builder retest this please |
1 similar comment
|
@ros-pull-request-builder retest this please |
Use defusedxml in rosmaster
I'm not sure if this is the best way to do it (particularly the "del" statement), but anyway defusedxml.monkey_patch() shuts down a bunch of different ways to blow up XML-RPC servers.