This repository was archived by the owner on May 31, 2025. It is now read-only.
Closed
Conversation
tools/rosmsg/package.xml
Outdated
| <run_depend>rosbag</run_depend> | ||
| <run_depend>roslib</run_depend> | ||
|
|
||
| <test_depend>geometry_msgs</test_depend> |
Member
There was a problem hiding this comment.
Currently nothing in this repository depends on common_msgs. Therefore I think this should be avoided and local custom messages should be used for these tests.
Contributor
Author
There was a problem hiding this comment.
In 1437c60 I deleted test_rosmsgproto_geometry_py and added to test_rosmsgproto.py tests of similar complexity to the deleted tests, but only using messages from std_msgs. The resulting test suite is not identical to the previous suite, but I don't see any significant changes in coverage.
Member
|
Thanks. Recreated against kinetic-devel: #826 In the future please comment on the pull request when committing changes in order to notify people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #751, where my branch got mangled to a point that I couldn't squash the commits. This branch contains the same changes as
enable_tests, where on the last build all tests passed on Indigo, and there was one apparently spurious timing failure inrostest:Thanks much to @dhood for the help!