This repository was archived by the owner on May 31, 2025. It is now read-only.
Closed
Conversation
Fixed most tests by replacing test_ros with test_rosmaster, which is apparently the new location for the messages and services that this test suite needs. There are still a few failing tests, which look like actual problems, related to how rosmsg, in raw mode, is resolving types that appear elsewhere, like `Empty`.
…kage names prepended like get_msg_text(_,raw=False) does
…age names prepended like get_srv_text(,raw=False) does
Fix remaining rosmsg tests
Member
|
The failing test from roswtf ( |
Member
|
@ros-pull-request-builder retest this please |
enable compiler warnings
Add pass_all_args attr to include tag
Fix minor python issues
roslaunch-check fails for heqtor_quadrotor_gazebo ``` $ rosrun roslaunch roslaunch-check /opt/ros/indigo/share/hector_quadrotor_gazebo/launch/quadrotor_empty_world.launch checking /opt/ros/indigo/share/hector_quadrotor_gazebo/launch/quadrotor_empty_world.launch ...writing test results to /home/k-okada/.ros/test_results/hector_quadrotor_gazebo/rosunit-roslaunch_check_quadrotor_empty_world_launch.xml FAILURE: [/opt/ros/indigo/share/hector_quadrotor_gazebo/launch/quadrotor_empty_world.launch]: Missing package dependencies: hector_quadrotor_gazebo/package.xml: gazebo_ros, hector_quadrotor_controller Missing package dependencies: hector_quadrotor_controller/package.xml: controller_manager ``` but it has dependency like ``` $ rospack depends-why --target gazebo_ros hector_quadrotor_gazebo Dependency chains from hector_quadrotor_gazebo to gazebo_ros: * hector_quadrotor_gazebo -> gazebo_plugins -> gazebo_ros * hector_quadrotor_gazebo -> hector_gazebo_plugins -> gazebo_ros * hector_quadrotor_gazebo -> hector_sensors_gazebo -> gazebo_plugins -> gazebo_ros * hector_quadrotor_gazebo -> hector_sensors_gazebo -> hector_gazebo_plugins -> gazebo_ros * hector_quadrotor_gazebo -> hector_quadrotor_gazebo_plugins -> gazebo_ros * hector_quadrotor_gazebo -> hector_quadrotor_gazebo_plugins -> hector_gazebo_plugins -> gazebo_ros * hector_quadrotor_gazebo -> hector_quadrotor_controller_gazebo -> gazebo_ros_control -> gazebo_ros ```
do not fail if other package.xml provides package required
…param to stdout. If no filename is passed to rosparam load or if '-' is passed as the filename, rosparam will attempt to read yaml from stdin. This allows piping yaml into rosparam. If no filename is specified to rosparam dump or if the filename is "-", dumps the rosparam yaml to stdout, allowing it to be piped into other programs.
wall-time option for rostopic hz
Fixed most tests by replacing test_ros with test_rosmaster, which is apparently the new location for the messages and services that this test suite needs. There are still a few failing tests, which look like actual problems, related to how rosmsg, in raw mode, is resolving types that appear elsewhere, like `Empty`.
…kage names prepended like get_msg_text(_,raw=False) does
…age names prepended like get_srv_text(,raw=False) does
…are used in the tests
Contributor
Author
|
The test failures were caused by: I added a |
Contributor
Author
|
Replaced by #764. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #709, the test suite for
rosmsghas long been disabled. This PR enables the test suite and updates the tests to make them pass. In some cases, it could be argued that instead the code should be updated instead of the tests. But I feel that's it's less risky to update the tests to match the long-standing behavior of the code.