This repository was archived by the owner on May 31, 2025. It is now read-only.
Small fixes for Python 3 compatibility.#565
Closed
aballier wants to merge 6 commits intoros:indigo-develfrom
Closed
Small fixes for Python 3 compatibility.#565aballier wants to merge 6 commits intoros:indigo-develfrom
aballier wants to merge 6 commits intoros:indigo-develfrom
Conversation
… compare or decode accordingly. Fixes this test with python3.
…thon 2 & 3. Since it is a test, performance does not matter much.
Member
|
Can one of the admins verify this patch? |
Member
Member
|
Test passed. |
|
+1 |
Member
|
@ros-pull-request-builder retest this please |
Member
|
Please resolve the merge conflicts to allow Jenkins to test the patch. |
Member
|
@mikepurvis might look into resolving conflicts on this one and targeting kinetic-devel. |
mikepurvis
added a commit
that referenced
this pull request
Feb 9, 2017
* tcpros_service.py: encode error messages as bytes in python3 before packing them. * test_rospy_tcpros_base.py: check against bytes equality for python3 compatibility. * test_rospy_tcpros_pubsub.py: use bytes data instead of str for python3 compatibility. * test_rospy_topics.py: check for bytes equality for python3 compatibility * test_rosservice_command_line_online.py: pipes are bytes with python3, compare or decode accordingly. Fixes this test with python3. * test_bag.py: use range() instead of xrange() so that it works with python 2 & 3. Since it is a test, performance does not matter much.
mikepurvis
pushed a commit
that referenced
this pull request
Feb 9, 2017
* tcpros_service.py: encode error messages as bytes in python3 before packing them. * test_rospy_tcpros_base.py: check against bytes equality for python3 compatibility. * test_rospy_tcpros_pubsub.py: use bytes data instead of str for python3 compatibility. * test_rospy_topics.py: check for bytes equality for python3 compatibility * test_rosservice_command_line_online.py: pipes are bytes with python3, compare or decode accordingly. Fixes this test with python3. * test_bag.py: use range() instead of xrange() so that it works with python 2 & 3. Since it is a test, performance does not matter much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a set of small independent patches to improve python 3 compatibility. These can be squashed if desired.
I have a few more pending but their correctness is more debatable.