keep the persistent connection only if rosmaster supports http1.1 by iuhilnehc-ynos · Pull Request #2208 · ros/ros_comm

iuhilnehc-ynos · 2021-11-30T09:42:55Z

Signed-off-by: Chen Lihui lihui.chen@sony.com

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

fujitatomoya · 2021-11-30T22:00:33Z

@sloretz @jacobperron @mjcarroll friendly ping, requesting maintainer review.

jacobperron

The changes look okay to me, but this breaks ABI. I'd rather not release an ABI-breaking change into an already released distribution. Maybe there's a way to make this fix ABI-compatible?

jacobperron · 2021-12-02T19:03:18Z

utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcClient.h

    bool _executing;

+    // True if the server supports HTTP1.1
+    bool _server_http_1_1;


This change breaks ABI.

but this breaks ABI.

our bad, that should be kept...sorry.

I knew it breaks ABI, but it's clear.
I tried to use _connectionState, but some source code might be as

enum ClientConnectionState { NO_CONNECTION, CONNECTING, WRITE_REQUEST, READ_HEADER, READ_RESPONSE, IDLE, CLIENT_CONNECT_STATE_MASK = 0xFFFF, SERVER_HTTP_DISCONNECT = 0x10000}; check header to set _connectionState: _connectionState |= SERVER_HTTP_DISCONNECT; set: _connectionState = READ_HEADER; --> _connectionState |= READ_HEADER; if (_connectionState == WRITE_REQUEST) --> if (_connectionState & CLIENT_CONNECT_STATE_MASK == WRITE_REQUEST) check if SERVER_HTTP_DISCONNECT: if (_connectionState & SERVER_HTTP_DISCONNECT)

~~do you think it's acceptable?~~
It seems to not work fine.

Do you have any other suggestions? I'd like to hear that.

I'll make use of the _header member variable, make it not clean after XmlRpcClient::readHeader, and then check it here and clean it.

…p1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com>

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

peci1 · 2021-12-03T12:08:04Z

I confirm this patch fixed #2182 for me on Jetson Xavier AGX (kernel 4.9.253) running Melodic. Also, the performance from #2132 is not affected.

Thanks a lot for investigating!

jacobperron

LGTM, thanks for the fix!

utilities/xmlrpcpp/src/XmlRpcClient.cpp

peci1 · 2022-01-05T15:34:51Z

Should I take care of the Melodic backport? Or is it planned?

jacobperron · 2022-01-05T22:34:06Z

Should I take care of the Melodic backport? Or is it planned?

I think a maintainer can include it in a backport PR, e.g. #2152

) * keep the persistent connection only if rosmaster supports http1.1 Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Revert "keep the persistent connection only if rosmaster supports http1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix without breaking ABI Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Update comment Co-authored-by: Jacob Perron <jacob@openrobotics.org>

…s#2208) * keep the persistent connection only if rosmaster supports http1.1 Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Revert "keep the persistent connection only if rosmaster supports http1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix without breaking ABI Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Update comment Co-authored-by: Jacob Perron <jacob@openrobotics.org>

@jacobperron

* Fix memory leak in rosgraph for kernel < 4.16 and Python 3 (ros#2165) (cherry picked from commit c7c5bcb) * Fix ros#2123: Do not raise exception if socket is busy in TCPROSTransport (ros#2131) Make behavior consistent with the C++ implementation. Co-authored-by: 229143434@qq.com <zxcvbnm123-*@> (cherry picked from commit b3f8e3c) * [xmlrpcpp] Fix build when gtest is not available (ros#2177) When gtest is not available, the target test_socket is not created by catkin_add_gtest (it provides a warning that gtest was not found and does not add the test). Trying to set the target properties then leads to a configuration error. Making this block conditional on the existence of the target fixes the configuration error. (cherry picked from commit 98545f8) * Do not set self.transport unless persistent in ServiceProxy (ros#2171) Co-authored-by: Kevin Chang <kevin.chang@aeolusdev.com> (cherry picked from commit c977e1e) * Fix warning related to Boost bind placeholders declared in global namespace. (ros#2169) * clients/roscpp/include/ros: publisher.h: Fix warning related to Boost bind placeholders declared in global namespace. This commit fixes the following: Warning: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior. Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com> * clients/roscpp/include/ros: node_handle.h: Fix warning related to Boost bind placeholders declared in global namespace. This commit fixes the following: Warning: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior. Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com> (cherry picked from commit 3294299) * [rospy] add current_real docstring in timer.py (ros#2178) * add current_reald doc in timer.py * fix docstring in timer.py Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 11ebadc) * Noetic: Fix XMLRPC endless loop (ros#2185) * Fix oversize string test. It claims to be "well-formed", but the closing tag was wrong. Fix that here. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add defensive checks for offset being NULL. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add unit tests for XML tag utility functions. This includes parseTag, findTag, nextTagIs, and getNextTag. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add implementation of nextTagData. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Switch structFromXml to using nextTagData. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit 41a956c) * Revert "Fix warning related to Boost bind placeholders declared in global namespace. (ros#2169)" (ros#2187) This reverts commit 3294299. (cherry picked from commit b9bd85d) * keep the persistent connection only if rosmaster supports http1.1 (ros#2208) * keep the persistent connection only if rosmaster supports http1.1 Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Revert "keep the persistent connection only if rosmaster supports http1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix without breaking ABI Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Update comment Co-authored-by: Jacob Perron <jacob@openrobotics.org> * Fix $(dirname) resolution in include tags (ros#2173) * roslaunch: Extend $(dirname) test * roslaunch include: Resolve substitution args w.r.t. parent's context to ensure that $(dirname) resolves to parent's dir * Correct missed boost::placeholders::_7 (ros#2242) * Add a workaround for a race condition while closing the socket (ros#2212) (ros#2233) Co-authored-by: Daniele Calisi <calisi@magazino.eu> * rosbag reindex bugfix - seek to truncated position after broken chunk (ros#2286) The truncate operation left the current `f.tell()` read head at the pre-truncated position, so the chunk infos that are written on closing the file started writing at this pre-truncated position, leaving dangling broken chunk data in between the last good chunk and the first file-end chunkinfo. Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> * Set TCP_NODELAY. (ros#2293) (cherry picked from commit f03fd33) * Add missing include (ros#2248) (cherry picked from commit 5edee4e) * Move @jacobperron from maintainer to author (ros#2302) Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 99a1ce0) * Fix determining supported kernel version for HTTP 1.1 (ros#2202) Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> (cherry picked from commit 047716c) * --noarr and --nostr option in rosservice call (ros#2307) (cherry picked from commit 1a1564e) * [topic_tools/mux] add wait_publisher_initialization option in mux (ros#2305) * [topic_tools] add wait_publisher_initialization option in mux * add wait_publisher_second param (cherry picked from commit 13dc820) * Fix error "s is not defined" (reopening ros#2320 again) (ros#2328) * Fix error "s is not defined" (reopening Refs ros#2320 again) * Update clients/rospy/src/rospy/topics.py with suggestion Co-authored-by: Martin Pecka <peci1@seznam.cz> --------- Co-authored-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 030e132) * Added init_options::NoSimTime to forcefully disable subscribing to /clock (ros#2342) * Added init_options::NoSimTime to forcefully disable subscribing to /clock. * Fix enum value * Added test for init_options::NoSimTime * Fixed test (cherry picked from commit b1ef2ee) * Fixed ROSCONSOLE_FORMAT with microseconds (ros#2370) (cherry picked from commit aef16f0) * Fixed uninitialized Time usage in rosservice call (ros#2369) (cherry picked from commit de95e28) * [windows] Remove python2 specific hack (ros#2364) This PR ros#1872 made windows act differently than linux because of a specific python 2 delay doing unnecessary DNS checks for localhost. The underlying code in python is different for python3 so the hack is no longer necessary. Given that, its better to reunify the codebase (cherry picked from commit cf0f276) * Fix segfault with default-constructed rosbag::ChunkedFile::swap (ros#2363) Closes ros#2362. (cherry picked from commit 3ad1409) * Fix rostest target names when build dir is inside source dir (ros#2361) It's a common approach to build cmake projects in a `build` folder in the project root. It's just that `rosbuild`/`catkin` does not do it, so the changed name never mattered. When you try the target name includes another `build_` string and there is *exactly one* package in the whole ecosystem that relies on this not happening: https://github.com/ros/ros_comm/blob/845f74602c7464e08ef5ac6fd9e26c97d0fe42c9/test/test_rosbag/bag_migration_tests/CMakeLists.txt#L87-L103 (cherry picked from commit 336b29a) * apply patch to fix build with boost 1.83.0 (ros#2354) (cherry picked from commit 0b0076d) * Update: #include <boost/bind.hpp> -> <boost/bind/bind.hpp> for boost 1.73 (ros#2348) * Update: #include <boost/bind.hpp> -> <boost/bind/bind.hpp> for boost 1.73 Since boost 1.73, i.e. on Ubuntu 22.04, the old header issues a deprecation warning: ``` /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’ ``` While the new header <boost/bind/bind.hpp> is available for a long time (on 18.04 already) and the source has been updated to use boost::placeholders in ros#2023, the header was not yet updated. * For backwards compatibility: pull placeholders into global namespace (cherry picked from commit 076ea3f) * add --min-space option to the python cli of rosbag record (ros#2298) (cherry picked from commit 1b1e7da) * Fix EINTR handling in XmlRpcDispatch::work (ros#2278) * Fix EINTR handling in XmlRpcDispatch::work * Document the XmlRpcDispatch::work behavior we receiving EINTR (cherry picked from commit 3337133) * Expose is_shutdown_requested in rospy namespace. (ros#2267) Just like the C++ `ros::isShuttingDown()`, this can be useful in certain cases where shutdown needs to be checked before all shutdown handlers finished. The difference to `is_shutdown()` is already clearly described in the docstring of `is_shutdown_requested()`. (cherry picked from commit c27175c) * rosnode: allow rosrun & roslaunch to find script (ros#2262) By installing the script in the "package bin destination" as well as letting setup.py install it in the global 'bin' directory. This is similar to what rosservice et al., which do work with roslaunch and rosrun. Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl> (cherry picked from commit 31ddca1) * rosbag_main.py: fix calling uncallable signal handler object (ros#2235) (ros#2236) Co-authored-by: Yannik Nager <yannik@sunflower-labs.com> (cherry picked from commit ce22d1c) * Fix printing XmlRpcValue with GTest (ros#2224) * Fix printing XmlRpcValue with GTest * Added tests for XmlRpc::PrintTo() * Make PrintTo inline (cherry picked from commit 13e4bd0) * check if ignore_unset_args is set in xmlloader (ros#2217) (cherry picked from commit 8917094) * Address DeprecationWarning (ros#2191) (cherry picked from commit d7ddd80) * fix typo t_start -> self.t_start (ros#2183) fix typo local t_start is not defined here, need to use self.t_start (cherry picked from commit eb8bb69) * Exposed record snapshot feature for command line. (ros#2254) (cherry picked from commit ecbb123) * rostest: add subscribetest (ros#2184) * rostest: add subscribetest This PR adds `subscribetest` node to check if the specified topics are subscribed. The usage is almost the same as `publishtest`: ``` <test test-name="subscribetest_test" pkg="rostest" type="subscribetest" time-limit="7.0" retry="3"> <rosparam> topics: - name: /chatter timeout: 2. - name: /subscribed_topic timeout: 2. negative: true </rosparam> </test> ``` * install nodes/subscribetest (cherry picked from commit 5067f44) --------- Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Co-authored-by: Alexis Schad <a@mandelbro.com> Co-authored-by: 金梦磊 <229143434@qq.com> Co-authored-by: Wolfgang Merkt <wxmerkt@users.noreply.github.com> Co-authored-by: Kevin Chang <kevinshchang@gmail.com> Co-authored-by: Elvis Dowson <elvis.dowson@gmail.com> Co-authored-by: Shingo Kitagawa <knorth55@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> Co-authored-by: Lucas Walter <wsacul@gmail.com> Co-authored-by: madmage <daniele.calisi@gmail.com> Co-authored-by: Daniele Calisi <calisi@magazino.eu> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Co-authored-by: Rik Baehnemann <brik@ethz.ch> Co-authored-by: Jochen Sprickerhof <git@jochen.sprickerhof.de> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: vineet131 <vineet131@users.noreply.github.com> Co-authored-by: Griffin Tabor <tabor473@gmail.com> Co-authored-by: Hugal31 <hugo.laloge@gmail.com> Co-authored-by: Michael Görner <me@v4hn.de> Co-authored-by: daizhirui <daizhirui@hotmail.com> Co-authored-by: Zijun Xu <30411902+Jeffxzj@users.noreply.github.com> Co-authored-by: Michael Grupp <grupp@magazino.eu> Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl> Co-authored-by: Yannik Nager <yannik.nager@gmail.com> Co-authored-by: Guglielmo Gemignani <2789215+g-gemignani@users.noreply.github.com> Co-authored-by: Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp> Co-authored-by: Blake Anderson <blakeanderson@utexas.edu>

@jacobperron

* Run tests in Jenkins * removed manual jenkinsfile * Sync with upstream (#44) * Fix memory leak in rosgraph for kernel < 4.16 and Python 3 (ros#2165) (cherry picked from commit c7c5bcb) * Fix ros#2123: Do not raise exception if socket is busy in TCPROSTransport (ros#2131) Make behavior consistent with the C++ implementation. Co-authored-by: 229143434@qq.com <zxcvbnm123-*@> (cherry picked from commit b3f8e3c) * [xmlrpcpp] Fix build when gtest is not available (ros#2177) When gtest is not available, the target test_socket is not created by catkin_add_gtest (it provides a warning that gtest was not found and does not add the test). Trying to set the target properties then leads to a configuration error. Making this block conditional on the existence of the target fixes the configuration error. (cherry picked from commit 98545f8) * Do not set self.transport unless persistent in ServiceProxy (ros#2171) Co-authored-by: Kevin Chang <kevin.chang@aeolusdev.com> (cherry picked from commit c977e1e) * Fix warning related to Boost bind placeholders declared in global namespace. (ros#2169) * clients/roscpp/include/ros: publisher.h: Fix warning related to Boost bind placeholders declared in global namespace. This commit fixes the following: Warning: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior. Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com> * clients/roscpp/include/ros: node_handle.h: Fix warning related to Boost bind placeholders declared in global namespace. This commit fixes the following: Warning: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior. Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com> (cherry picked from commit 3294299) * [rospy] add current_real docstring in timer.py (ros#2178) * add current_reald doc in timer.py * fix docstring in timer.py Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 11ebadc) * Noetic: Fix XMLRPC endless loop (ros#2185) * Fix oversize string test. It claims to be "well-formed", but the closing tag was wrong. Fix that here. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add defensive checks for offset being NULL. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add unit tests for XML tag utility functions. This includes parseTag, findTag, nextTagIs, and getNextTag. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add implementation of nextTagData. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Switch structFromXml to using nextTagData. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit 41a956c) * Revert "Fix warning related to Boost bind placeholders declared in global namespace. (ros#2169)" (ros#2187) This reverts commit 3294299. (cherry picked from commit b9bd85d) * keep the persistent connection only if rosmaster supports http1.1 (ros#2208) * keep the persistent connection only if rosmaster supports http1.1 Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Revert "keep the persistent connection only if rosmaster supports http1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix without breaking ABI Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Update comment Co-authored-by: Jacob Perron <jacob@openrobotics.org> * Fix $(dirname) resolution in include tags (ros#2173) * roslaunch: Extend $(dirname) test * roslaunch include: Resolve substitution args w.r.t. parent's context to ensure that $(dirname) resolves to parent's dir * Correct missed boost::placeholders::_7 (ros#2242) * Add a workaround for a race condition while closing the socket (ros#2212) (ros#2233) Co-authored-by: Daniele Calisi <calisi@magazino.eu> * rosbag reindex bugfix - seek to truncated position after broken chunk (ros#2286) The truncate operation left the current `f.tell()` read head at the pre-truncated position, so the chunk infos that are written on closing the file started writing at this pre-truncated position, leaving dangling broken chunk data in between the last good chunk and the first file-end chunkinfo. Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> * Set TCP_NODELAY. (ros#2293) (cherry picked from commit f03fd33) * Add missing include (ros#2248) (cherry picked from commit 5edee4e) * Move @jacobperron from maintainer to author (ros#2302) Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 99a1ce0) * Fix determining supported kernel version for HTTP 1.1 (ros#2202) Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> (cherry picked from commit 047716c) * --noarr and --nostr option in rosservice call (ros#2307) (cherry picked from commit 1a1564e) * [topic_tools/mux] add wait_publisher_initialization option in mux (ros#2305) * [topic_tools] add wait_publisher_initialization option in mux * add wait_publisher_second param (cherry picked from commit 13dc820) * Fix error "s is not defined" (reopening ros#2320 again) (ros#2328) * Fix error "s is not defined" (reopening Refs ros#2320 again) * Update clients/rospy/src/rospy/topics.py with suggestion Co-authored-by: Martin Pecka <peci1@seznam.cz> --------- Co-authored-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 030e132) * Added init_options::NoSimTime to forcefully disable subscribing to /clock (ros#2342) * Added init_options::NoSimTime to forcefully disable subscribing to /clock. * Fix enum value * Added test for init_options::NoSimTime * Fixed test (cherry picked from commit b1ef2ee) * Fixed ROSCONSOLE_FORMAT with microseconds (ros#2370) (cherry picked from commit aef16f0) * Fixed uninitialized Time usage in rosservice call (ros#2369) (cherry picked from commit de95e28) * [windows] Remove python2 specific hack (ros#2364) This PR ros#1872 made windows act differently than linux because of a specific python 2 delay doing unnecessary DNS checks for localhost. The underlying code in python is different for python3 so the hack is no longer necessary. Given that, its better to reunify the codebase (cherry picked from commit cf0f276) * Fix segfault with default-constructed rosbag::ChunkedFile::swap (ros#2363) Closes ros#2362. (cherry picked from commit 3ad1409) * Fix rostest target names when build dir is inside source dir (ros#2361) It's a common approach to build cmake projects in a `build` folder in the project root. It's just that `rosbuild`/`catkin` does not do it, so the changed name never mattered. When you try the target name includes another `build_` string and there is *exactly one* package in the whole ecosystem that relies on this not happening: https://github.com/ros/ros_comm/blob/845f74602c7464e08ef5ac6fd9e26c97d0fe42c9/test/test_rosbag/bag_migration_tests/CMakeLists.txt#L87-L103 (cherry picked from commit 336b29a) * apply patch to fix build with boost 1.83.0 (ros#2354) (cherry picked from commit 0b0076d) * Update: #include <boost/bind.hpp> -> <boost/bind/bind.hpp> for boost 1.73 (ros#2348) * Update: #include <boost/bind.hpp> -> <boost/bind/bind.hpp> for boost 1.73 Since boost 1.73, i.e. on Ubuntu 22.04, the old header issues a deprecation warning: ``` /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’ ``` While the new header <boost/bind/bind.hpp> is available for a long time (on 18.04 already) and the source has been updated to use boost::placeholders in ros#2023, the header was not yet updated. * For backwards compatibility: pull placeholders into global namespace (cherry picked from commit 076ea3f) * add --min-space option to the python cli of rosbag record (ros#2298) (cherry picked from commit 1b1e7da) * Fix EINTR handling in XmlRpcDispatch::work (ros#2278) * Fix EINTR handling in XmlRpcDispatch::work * Document the XmlRpcDispatch::work behavior we receiving EINTR (cherry picked from commit 3337133) * Expose is_shutdown_requested in rospy namespace. (ros#2267) Just like the C++ `ros::isShuttingDown()`, this can be useful in certain cases where shutdown needs to be checked before all shutdown handlers finished. The difference to `is_shutdown()` is already clearly described in the docstring of `is_shutdown_requested()`. (cherry picked from commit c27175c) * rosnode: allow rosrun & roslaunch to find script (ros#2262) By installing the script in the "package bin destination" as well as letting setup.py install it in the global 'bin' directory. This is similar to what rosservice et al., which do work with roslaunch and rosrun. Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl> (cherry picked from commit 31ddca1) * rosbag_main.py: fix calling uncallable signal handler object (ros#2235) (ros#2236) Co-authored-by: Yannik Nager <yannik@sunflower-labs.com> (cherry picked from commit ce22d1c) * Fix printing XmlRpcValue with GTest (ros#2224) * Fix printing XmlRpcValue with GTest * Added tests for XmlRpc::PrintTo() * Make PrintTo inline (cherry picked from commit 13e4bd0) * check if ignore_unset_args is set in xmlloader (ros#2217) (cherry picked from commit 8917094) * Address DeprecationWarning (ros#2191) (cherry picked from commit d7ddd80) * fix typo t_start -> self.t_start (ros#2183) fix typo local t_start is not defined here, need to use self.t_start (cherry picked from commit eb8bb69) * Exposed record snapshot feature for command line. (ros#2254) (cherry picked from commit ecbb123) * rostest: add subscribetest (ros#2184) * rostest: add subscribetest This PR adds `subscribetest` node to check if the specified topics are subscribed. The usage is almost the same as `publishtest`: ``` <test test-name="subscribetest_test" pkg="rostest" type="subscribetest" time-limit="7.0" retry="3"> <rosparam> topics: - name: /chatter timeout: 2. - name: /subscribed_topic timeout: 2. negative: true </rosparam> </test> ``` * install nodes/subscribetest (cherry picked from commit 5067f44) --------- Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Co-authored-by: Alexis Schad <a@mandelbro.com> Co-authored-by: 金梦磊 <229143434@qq.com> Co-authored-by: Wolfgang Merkt <wxmerkt@users.noreply.github.com> Co-authored-by: Kevin Chang <kevinshchang@gmail.com> Co-authored-by: Elvis Dowson <elvis.dowson@gmail.com> Co-authored-by: Shingo Kitagawa <knorth55@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> Co-authored-by: Lucas Walter <wsacul@gmail.com> Co-authored-by: madmage <daniele.calisi@gmail.com> Co-authored-by: Daniele Calisi <calisi@magazino.eu> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Co-authored-by: Rik Baehnemann <brik@ethz.ch> Co-authored-by: Jochen Sprickerhof <git@jochen.sprickerhof.de> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: vineet131 <vineet131@users.noreply.github.com> Co-authored-by: Griffin Tabor <tabor473@gmail.com> Co-authored-by: Hugal31 <hugo.laloge@gmail.com> Co-authored-by: Michael Görner <me@v4hn.de> Co-authored-by: daizhirui <daizhirui@hotmail.com> Co-authored-by: Zijun Xu <30411902+Jeffxzj@users.noreply.github.com> Co-authored-by: Michael Grupp <grupp@magazino.eu> Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl> Co-authored-by: Yannik Nager <yannik.nager@gmail.com> Co-authored-by: Guglielmo Gemignani <2789215+g-gemignani@users.noreply.github.com> Co-authored-by: Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp> Co-authored-by: Blake Anderson <blakeanderson@utexas.edu> --------- Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> Co-authored-by: Alexis Schad <a@mandelbro.com> Co-authored-by: 金梦磊 <229143434@qq.com> Co-authored-by: Wolfgang Merkt <wxmerkt@users.noreply.github.com> Co-authored-by: Kevin Chang <kevinshchang@gmail.com> Co-authored-by: Elvis Dowson <elvis.dowson@gmail.com> Co-authored-by: Shingo Kitagawa <knorth55@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> Co-authored-by: Lucas Walter <wsacul@gmail.com> Co-authored-by: madmage <daniele.calisi@gmail.com> Co-authored-by: Daniele Calisi <calisi@magazino.eu> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Co-authored-by: Rik Baehnemann <brik@ethz.ch> Co-authored-by: Jochen Sprickerhof <git@jochen.sprickerhof.de> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: vineet131 <vineet131@users.noreply.github.com> Co-authored-by: Griffin Tabor <tabor473@gmail.com> Co-authored-by: Hugal31 <hugo.laloge@gmail.com> Co-authored-by: Michael Görner <me@v4hn.de> Co-authored-by: daizhirui <daizhirui@hotmail.com> Co-authored-by: Zijun Xu <30411902+Jeffxzj@users.noreply.github.com> Co-authored-by: Michael Grupp <grupp@magazino.eu> Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl> Co-authored-by: Yannik Nager <yannik.nager@gmail.com> Co-authored-by: Guglielmo Gemignani <2789215+g-gemignani@users.noreply.github.com> Co-authored-by: Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp> Co-authored-by: Blake Anderson <blakeanderson@utexas.edu>

…s#2208) * keep the persistent connection only if rosmaster supports http1.1 Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Revert "keep the persistent connection only if rosmaster supports http1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix without breaking ABI Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Update comment Co-authored-by: Jacob Perron <jacob@openrobotics.org>

keep the persistent connection only if rosmaster supports http1.1

2cb7602

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

fujitatomoya approved these changes Nov 30, 2021

View reviewed changes

jacobperron reviewed Dec 2, 2021

View reviewed changes

Revert "keep the persistent connection only if rosmaster supports htt…

0ba7104

…p1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com>

iuhilnehc-ynos force-pushed the topic-server-not-support-http_1_1 branch from 2a3f123 to 7750cc5 Compare December 3, 2021 04:46

fix without breaking ABI

7750cc5

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

jacobperron approved these changes Dec 3, 2021

View reviewed changes

utilities/xmlrpcpp/src/XmlRpcClient.cpp Outdated Show resolved Hide resolved

Update comment

f82f4b2

jacobperron merged commit a1b9433 into ros:noetic-devel Dec 3, 2021

jacobperron added the consider-backport label Dec 3, 2021

peci1 mentioned this pull request Jan 6, 2022

Changes between 1.15.11 and 1.15.14 for backporting to Melodic #2219

Merged

peci1 mentioned this pull request Jan 19, 2022

Large delays when communicating with rosmaster on noetic running in docker container on an ARM64 jetson TX2 #2156

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keep the persistent connection only if rosmaster supports http1.1#2208

keep the persistent connection only if rosmaster supports http1.1#2208
jacobperron merged 4 commits intoros:noetic-develfrom
iuhilnehc-ynos:topic-server-not-support-http_1_1

iuhilnehc-ynos commented Nov 30, 2021

Uh oh!

fujitatomoya commented Nov 30, 2021

Uh oh!

jacobperron left a comment

Uh oh!

jacobperron Dec 2, 2021 •

edited

Loading

Uh oh!

fujitatomoya Dec 2, 2021

Uh oh!

iuhilnehc-ynos Dec 3, 2021 •

edited

Loading

Uh oh!

iuhilnehc-ynos Dec 3, 2021

Uh oh!

iuhilnehc-ynos Dec 3, 2021

Uh oh!

peci1 commented Dec 3, 2021

Uh oh!

jacobperron left a comment

Uh oh!

Uh oh!

peci1 commented Jan 5, 2022

Uh oh!

jacobperron commented Jan 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

iuhilnehc-ynos commented Nov 30, 2021

Uh oh!

fujitatomoya commented Nov 30, 2021

Uh oh!

jacobperron left a comment

Choose a reason for hiding this comment

Uh oh!

jacobperron Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fujitatomoya Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

iuhilnehc-ynos Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iuhilnehc-ynos Dec 3, 2021

Choose a reason for hiding this comment

Uh oh!

iuhilnehc-ynos Dec 3, 2021

Choose a reason for hiding this comment

Uh oh!

peci1 commented Dec 3, 2021

Uh oh!

jacobperron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

peci1 commented Jan 5, 2022

Uh oh!

jacobperron commented Jan 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jacobperron Dec 2, 2021 •

edited

Loading

iuhilnehc-ynos Dec 3, 2021 •

edited

Loading