This repository was archived by the owner on May 31, 2025. It is now read-only.
Use Logger.warning() instead of the deprecated warn().#2120
Merged
jacobperron merged 1 commit intoros:noetic-develfrom Feb 1, 2021
Merged
Use Logger.warning() instead of the deprecated warn().#2120jacobperron merged 1 commit intoros:noetic-develfrom
jacobperron merged 1 commit intoros:noetic-develfrom
Conversation
Contributor
Author
|
The failed tests seems to be a C++ test, which given that the change was in Python suggests it's a flaky test. How can I rerun the tests to check it? |
Contributor
Contributor
|
@ros-pull-request-builder retest this please |
jacobperron
approved these changes
Feb 1, 2021
Contributor
jacobperron
left a comment
There was a problem hiding this comment.
Thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2106 for why this is important for us.