Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Portable fix to recent Windows build breaks.#2110

Merged
sloretz merged 4 commits intoros:noetic-develfrom
ms-iot:pr/1.15.9
Dec 30, 2020
Merged

Portable fix to recent Windows build breaks.#2110
sloretz merged 4 commits intoros:noetic-develfrom
ms-iot:pr/1.15.9

Conversation

@seanyen
Copy link
Copy Markdown
Contributor

@seanyen seanyen commented Dec 23, 2020

This pull request is to address recent Windows build breaks:

@seanyen seanyen closed this Dec 28, 2020
@seanyen seanyen reopened this Dec 28, 2020
@seanyen
Copy link
Copy Markdown
Contributor Author

seanyen commented Dec 28, 2020

Hmm, hope someone can help trigger the CI.

@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Dec 29, 2020

@seanyen It looks like CI ran and failed. Mind taking a look?

11:46:32 [  8%] Building CXX object CMakeFiles/xmlrpcpp.dir/src/XmlRpcClient.cpp.o
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp: In member function ‘virtual bool XmlRpc::XmlRpcClient::generateRequest(const char*, const XmlRpc::XmlRpcValue&)’:
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp:316:34: error: ‘INT_MAX’ was not declared in this scope
11:46:32   316 |   if (_request.length() > size_t(INT_MAX)) {
11:46:32       |                                  ^~~~~~~
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp:14:1: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
11:46:32    13 | #include <string.h>
11:46:32   +++ |+#include <climits>
11:46:32    14 | 
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp: In member function ‘virtual bool XmlRpc::XmlRpcClient::readHeader()’:
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp:444:36: error: ‘INT_MAX’ was not declared in this scope
11:46:32   444 |   if ((clength <= 0) || (clength > INT_MAX)) {
11:46:32       |                                    ^~~~~~~
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp:444:36: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp: In member function ‘virtual bool XmlRpc::XmlRpcClient::readResponse()’:
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp:478:37: error: ‘INT_MAX’ was not declared in this scope
11:46:32   478 |     if (_response.length() > size_t(INT_MAX)) {
11:46:32       |                                     ^~~~~~~
11:46:32 /tmp/ws/src/ros_comm/utilities/xmlrpcpp/src/XmlRpcClient.cpp:478:37: note: ‘INT_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
11:46:32 make[2]: *** [CMakeFiles/xmlrpcpp.dir/build.make:63: CMakeFiles/xmlrpcpp.dir/src/XmlRpcClient.cpp.o] Error 1
11:46:32 make[1]: *** [CMakeFiles/Makefile2:276: CMakeFiles/xmlrpcpp.dir/all] Error 2

sloretz
sloretz reviewed Dec 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, the rest LGTM :)

sloretz
sloretz approved these changes Dec 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI. Thanks for the PR!

@sloretz sloretz merged commit 08fcc09 into ros:noetic-devel Dec 30, 2020
jacobperron pushed a commit that referenced this pull request Apr 6, 2021
@seanyen @jacobperron
Portable fix to recent Windows build breaks. (#2110)
0c45f6d 
* Portable fix.

* include <climits>

* Adding missing headers.

* Adding #include <vector>
@jacobperron jacobperron mentioned this pull request Apr 6, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sloretz sloretz sloretz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seanyen @sloretz