This repository was archived by the owner on May 31, 2025. It is now read-only.
rosmsg: clean up test dependencies#2103
Merged
jacobperron merged 1 commit intoros:noetic-develfrom Mar 11, 2021
Merged
Conversation
All dependencies must be declared in the package.xml, and all these dependencies must be in the ROS distro. rosmsg doesn't meet either of these requirements today, by using but not depending on both rostest and std_srvs, and by using test_rosmaster, which isn't in the ROS distro at all. Update rosmsg to properly depend upon what it requires, and stop using test_rosmaster completely. In place of test_rosmaster, use diagnostic_msgs, which satisfies the same requirements of the existing tests by having both messages and services as well as standalone and recursive messages. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
jacobperron
approved these changes
Dec 10, 2020
Contributor
jacobperron
left a comment
There was a problem hiding this comment.
Seems reasonable to me, but I'd like to check-in with @sloretz and @mjcarroll for any reservations on introducing a test depend on diagnostic_msgs.
jacobperron
pushed a commit
that referenced
this pull request
Apr 6, 2021
All dependencies must be declared in the package.xml, and all these dependencies must be in the ROS distro. rosmsg doesn't meet either of these requirements today, by using but not depending on both rostest and std_srvs, and by using test_rosmaster, which isn't in the ROS distro at all. Update rosmsg to properly depend upon what it requires, and stop using test_rosmaster completely. In place of test_rosmaster, use diagnostic_msgs, which satisfies the same requirements of the existing tests by having both messages and services as well as standalone and recursive messages. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All dependencies must be declared in the package.xml, and all these dependencies must be in the ROS distro (see ros/rosdistro#27359). rosmsg doesn't meet either of these requirements today, by using but not depending on both rostest and std_srvs, and by using test_rosmaster, which isn't in the ROS distro at all.
Update rosmsg to properly depend upon what it requires, and stop using test_rosmaster completely. In place of test_rosmaster, use diagnostic_msgs, which satisfies the same requirements of the existing tests by having both messages and services as well as standalone and recursive messages.