This repository was archived by the owner on May 31, 2025. It is now read-only.
Fix AttributeError isAlive#2092
Merged
jacobperron merged 3 commits intoros:noetic-develfrom Dec 30, 2020
Merged
Conversation
|
There are still a few usages of It probably makes sense to change them as well. I am not sure if the |
Contributor
|
Thanks for the fix! I agree with @pschmutz about updating the remaining instances as well.
+1 for keeping it and adding a new @BrutusTT Do you mind updating this PR, replacing the other instances of isAlive as well? |
Keep mock method isAlive to keep backwards compatibility for users who happen to be using the mock object. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Contributor
|
I went ahead an updated the remaining instances of 'isAlive' (0efe27b). |
jacobperron
approved these changes
Dec 30, 2020
nim65s
added a commit
to nim65s/ros-noetic-rospy
that referenced
this pull request
Jan 22, 2021
fix:
```python
Traceback (most recent call last):
File "…/lib/controller_manager/spawner", line 212, in <module>
if __name__ == '__main__': main()
File "…/lib/controller_manager/spawner", line 210, in main
rospy.spin()
File "/opt/ros/noetic/lib/python3.9/site-packages/rospy/client.py", line 129, in spin
rospy.rostime.wallsleep(0.5)
File "/opt/ros/noetic/lib/python3.9/site-packages/rospy/rostime.py", line 277, in wallsleep
time.sleep(duration)
File "/opt/ros/noetic/lib/python3.9/site-packages/rospy/core.py", line 602, in _ros_signal
signal_shutdown("signal-"+str(sig))
File "/opt/ros/noetic/lib/python3.9/site-packages/rospy/core.py", line 594, in signal_shutdown
if t.isAlive():
AttributeError: 'Thread' object has no attribute 'isAlive'
```
ref: ros/ros_comm#2092
acxz
pushed a commit
to ros-noetic-arch/ros-noetic-rospy
that referenced
this pull request
Jan 25, 2021
fix:
```python
Traceback (most recent call last):
File "…/lib/controller_manager/spawner", line 212, in <module>
if __name__ == '__main__': main()
File "…/lib/controller_manager/spawner", line 210, in main
rospy.spin()
File "/opt/ros/noetic/lib/python3.9/site-packages/rospy/client.py", line 129, in spin
rospy.rostime.wallsleep(0.5)
File "/opt/ros/noetic/lib/python3.9/site-packages/rospy/rostime.py", line 277, in wallsleep
time.sleep(duration)
File "/opt/ros/noetic/lib/python3.9/site-packages/rospy/core.py", line 602, in _ros_signal
signal_shutdown("signal-"+str(sig))
File "/opt/ros/noetic/lib/python3.9/site-packages/rospy/core.py", line 594, in signal_shutdown
if t.isAlive():
AttributeError: 'Thread' object has no attribute 'isAlive'
```
ref: ros/ros_comm#2092
fmauch
added a commit
to ros-melodic-arch/ros-melodic-rospy
that referenced
this pull request
Apr 3, 2021
fmauch
added a commit
to ros-melodic-arch/ros-melodic-roslaunch
that referenced
this pull request
Apr 3, 2021
jacobperron
added a commit
that referenced
this pull request
Apr 6, 2021
* fix: roscore -> AttributeError: 'ProcessMonitor' object has no attribute 'isAlive' * Fix AttributeError: 'Thread' object has no attribute 'isAlive' * Update remaining instances of isAlive to is_alive Keep mock method isAlive to keep backwards compatibility for users who happen to be using the mock object. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
starting roscore results in:
However, the ProcessMonitor has a
is_alivemethod so I assume this is what was meant here.The same happens after closing rqt:
However, the Thread has a
is_alivemethod so I assume this is what was meant here.