This repository was archived by the owner on May 31, 2025. It is now read-only.
rosbag: start player in paused state#2086
Merged
jacobperron merged 1 commit intoros:noetic-develfrom Dec 10, 2020
Merged
Conversation
jacobperron
approved these changes
Dec 10, 2020
Contributor
jacobperron
left a comment
There was a problem hiding this comment.
I wasn't able to reproduce the race described, but the change looks okay to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
options.start_pausedparameter is set to true.Otherwise one could run into timing issues because the
paused_member variable was only set at a later stage when publishing messages from the bag:ros_comm/tools/rosbag/src/player.cpp
Line 229 in 090daa5
For instance: if one would set
options.start_paused = trueand immediately call the~/pause_playbackservice, the service call could return an error stating that the bag was already being replayed.