This repository was archived by the owner on May 31, 2025. It is now read-only.
Fix subscription busy wait melodic#2014
Merged
dirk-thomas merged 2 commits intomelodic-develfrom Jul 31, 2020
Merged
Conversation
Replace duplicate wait_for() call in CallbackQueue::callOne() with a loop and a call to wait_until().
…ely if timeout.isZero() ... and if none of the other result conditions holds (i.e. the queue is Empty or Disabled).
This was referenced Jul 31, 2020
This was referenced Jul 31, 2020
Closed
meyerj
added a commit
to meyerj/ros_comm
that referenced
this pull request
Oct 7, 2024
* roscpp: simplify implementation of CallbackQueue::callOne() Replace duplicate wait_for() call in CallbackQueue::callOne() with a loop and a call to wait_until(). * roscpp: return TryAgain from CallbackQueue::callOne(timeout) immediately if timeout.isZero() ... and if none of the other result conditions holds (i.e. the queue is Empty or Disabled). Co-authored-by: Johannes Meyer <johannes@intermodalics.eu>
meyerj
added a commit
to meyerj/ros_comm
that referenced
this pull request
Oct 7, 2024
* roscpp: simplify implementation of CallbackQueue::callOne() Replace duplicate wait_for() call in CallbackQueue::callOne() with a loop and a call to wait_until(). * roscpp: return TryAgain from CallbackQueue::callOne(timeout) immediately if timeout.isZero() ... and if none of the other result conditions holds (i.e. the queue is Empty or Disabled). Co-authored-by: Johannes Meyer <johannes@intermodalics.eu>
sloretz
pushed a commit
that referenced
this pull request
May 5, 2025
… long" (#2377) * * Fix a busy-wait loop in subscription queue. * Better fix for slow callbacks CPU throttling. * More versatile callback queue test. * Finished cherry-pick merge to melodic-devel. * libros: moved define * roscpp: implementet #1608 without ABI/API breaks * /test_roscpp: fake_message is in a header now... * test_roscpp: fixed sign-compare warning * stabilized test * CallbackQueue: use SteadyTime instead of WallTime to get independent of system-time changes * style only * Update clients/roscpp/include/ros/callback_queue.h Co-authored-by: Johannes Meyer <johannes@intermodalics.eu> Co-authored-by: Martin Pecka <peci1@seznam.cz> Co-authored-by: CTU base <robot@ctu-base> Co-authored-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: Christopher Wecht <christopher.wechtstudent.kit.edu> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: Johannes Meyer <johannes@intermodalics.eu> * Fix subscription busy wait melodic (#2014) * roscpp: simplify implementation of CallbackQueue::callOne() Replace duplicate wait_for() call in CallbackQueue::callOne() with a loop and a call to wait_until(). * roscpp: return TryAgain from CallbackQueue::callOne(timeout) immediately if timeout.isZero() ... and if none of the other result conditions holds (i.e. the queue is Empty or Disabled). Co-authored-by: Johannes Meyer <johannes@intermodalics.eu> --------- Co-authored-by: Christopher Wecht <cwecht@users.noreply.github.com> Co-authored-by: Martin Pecka <peci1@seznam.cz> Co-authored-by: CTU base <robot@ctu-base> Co-authored-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate of cwecht#1.
@meyerj FYI.