This repository was archived by the owner on May 31, 2025. It is now read-only.
fix windows build for rosbag_storage#1687
Merged
dirk-thomas merged 3 commits intoros:melodic-develfrom Apr 4, 2019
kejxu:fix_rosbag_storage_build_on_windows
Merged
fix windows build for rosbag_storage#1687dirk-thomas merged 3 commits intoros:melodic-develfrom kejxu:fix_rosbag_storage_build_on_windows
dirk-thomas merged 3 commits intoros:melodic-develfrom
kejxu:fix_rosbag_storage_build_on_windows
Conversation
Member
|
Thanks for the fix. For the record: the regression was introduce in #1499. |
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
* fix broken changes. (ros#55) Fix broken changes. * add comment, include rosbag_storage first * remove unhelpful comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.