#1502 revisited: roslaunch: Allow passing _TIMEOUT_SIGINT and _TIMEOUT_SIGTERM as parameters#1670
#1502 revisited: roslaunch: Allow passing _TIMEOUT_SIGINT and _TIMEOUT_SIGTERM as parameters#1670cwecht wants to merge 6 commits intoros:melodic-develfrom
Conversation
|
@ros-pull-request-builder retest this please |
|
This needs to be rebased to resolve conflicts. |
|
@cwecht Closing due to no response. Please consider to open a new pull request targeting |
|
@dirk-thomas Did you look at my PR? I know that @cwecht did not merge it, but I could easily try to retarget it here and not at @cwecht's repo. |
|
But I'd still like to target it to melodic. |
No, I haven't. Please feel free to open a new PR targeting
Any PR should target the default branch which is for the latest distro (now |
|
Okay, I'll have a look at it. |
|
Continued in #1937. |
|
#1937 has been merged into |
|
I will be considered as part of a backport PR before the next Melodic patch release. All commits from |
This replaces #1502. The suggested changes have been added. The argument-parser excepts now floats for '--sigint-timeout' and '--sigterm-timeout' to be consistent with DEFAULT_TIMEOUT_SIGINT and DEFAULT_TIMEOUT_SIGTERM.